Changeset 151558 in webkit

Timestamp:

Jun 13, 2013 10:03:17 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set.
​https://bugs.webkit.org/show_bug.cgi?id=117578.

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-06-13
Reviewed by Darin Adler.

ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent
even though 'onaudioprocess' listener is not set. This results in unwanted thread hops.
Code is optimized to dispatch AudioProcessingEvent only if the listener is set.

No new tests, already covered by existing tests.

• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::setOnaudioprocess):

• Modules/webaudio/ScriptProcessorNode.h:

(WebCore::ScriptProcessorNode::onaudioprocess):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/ScriptProcessorNode.cpp (modified) (3 diffs)
• Modules/webaudio/ScriptProcessorNode.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-13  Praveen R Jadhav  <praveen.j@samsung.com>
+
+        Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set.
+        https://bugs.webkit.org/show_bug.cgi?id=117578.
+
+        Reviewed by Darin Adler.
+
+        ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent
+        even though 'onaudioprocess' listener is not set. This results in unwanted thread hops.
+        Code is optimized to dispatch AudioProcessingEvent only if the listener is set.
+
+        No new tests, already covered by existing tests.
+
+        * Modules/webaudio/ScriptProcessorNode.cpp:
+        (WebCore::ScriptProcessorNode::ScriptProcessorNode):
+        (WebCore::ScriptProcessorNode::process):
+        (WebCore::ScriptProcessorNode::setOnaudioprocess):
+        * Modules/webaudio/ScriptProcessorNode.h:
+        (WebCore::ScriptProcessorNode::onaudioprocess):
+
 2013-06-13  Max Vujovic  <mvujovic@adobe.com>
 

trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp

@@ -81 +81 @@
     , m_numberOfOutputChannels(numberOfOutputChannels)
     , m_internalInputBus(AudioBus::create(numberOfInputChannels, AudioNode::ProcessingSizeInFrames, false))
+    , m_hasAudioProcessListener(false)
 {
     // Regardless of the allowed buffer sizes, we still need to process at the granularity of the AudioNode.
@@ -139 +140 @@
     // This node is the producer for inputBuffer and the consumer for outputBuffer.
     // The JavaScript code is the consumer of inputBuffer and the producer for outputBuffer.
-    
+
+    // Check if audioprocess listener is set.
+    if (!m_hasAudioProcessListener)
+        return;
+
     // Get input and output busses.
     AudioBus* inputBus = this->input(0)->bus();
@@ -215 +220 @@
 }
 
+void ScriptProcessorNode::setOnaudioprocess(PassRefPtr<EventListener> listener)
+{
+    m_hasAudioProcessListener = listener;
+    setAttributeEventListener(eventNames().audioprocessEvent, listener);
+}
+
 void ScriptProcessorNode::fireProcessEventDispatch(void* userData)
 {

trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h

@@ -66 +66 @@
     size_t bufferSize() const { return m_bufferSize; }
 
-    DEFINE_ATTRIBUTE_EVENT_LISTENER(audioprocess);
+    EventListener* onaudioprocess() { return getAttributeEventListener(eventNames().audioprocessEvent); }
+    void setOnaudioprocess(PassRefPtr<EventListener>);
     
 private:
@@ -93 +94 @@
 
     RefPtr<AudioBus> m_internalInputBus;
+    bool m_hasAudioProcessListener;
 };