Changeset 151807 in webkit

Timestamp:

Jun 20, 2013 3:15:34 PM (11 years ago)

Author:

enrica@apple.com

Message:

Initial advance on the first glyph of the run is not correctly set for rtl text.
​https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>

Reviewed by Sam Weinig.

Source/WebCore:

We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.

Test: fast/text/complex-first-glyph-with-initial-advance.html

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

• fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
• fast/text/complex-first-glyph-with-initial-advance.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/complex-first-glyph-with-initial-advance-expected.html (added)
• LayoutTests/fast/text/complex-first-glyph-with-initial-advance.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/mac/ComplexTextController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-20  Enrica Casucci  <enrica@apple.com>
+
+        Initial advance on the first glyph of the run is not correctly set for rtl text.
+        https://bugs.webkit.org/show_bug.cgi?id=117839
+        <rdar://problem/13860717>
+
+        Reviewed by Sam Weinig.
+
+        * fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
+        * fast/text/complex-first-glyph-with-initial-advance.html: Added.
+
 2013-06-20  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-20  Enrica Casucci  <enrica@apple.com>
+
+        Initial advance on the first glyph of the run is not correctly set for rtl text.
+        https://bugs.webkit.org/show_bug.cgi?id=117839
+        <rdar://problem/13860717>
+
+        Reviewed by Sam Weinig.
+
+        We need to set the initial advance to the glyphBuffer, using the
+        initial advance of the complex run that will be drawn first.
+        In order to choose the run correctly we must consider the text direction.
+
+        Test: fast/text/complex-first-glyph-with-initial-advance.html
+
+        * platform/graphics/mac/ComplexTextController.cpp:
+        (WebCore::ComplexTextController::advance):
+
 2013-06-20  Alex Christensen  <achristensen@apple.com>
 

trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp

@@ -497 +497 @@
             fallbackFonts->add(complexTextRun.fontData());
 
-        if (glyphBuffer && glyphBuffer->isEmpty())
+        // We must store the initial advance for the first glyph we are going to draw.
+        // When leftmostGlyph is 0, it represents the first glyph to draw, taking into
+        // account the text direction.
+        if (glyphBuffer && !leftmostGlyph)
             glyphBuffer->setInitialAdvance(complexTextRun.initialAdvance());