Changeset 151916 in webkit


Ignore:
Timestamp:
Jun 24, 2013 10:12:07 AM (11 years ago)
Author:
eric.carlson@apple.com
Message:

Potential crash when in-band track is removed
https://bugs.webkit.org/show_bug.cgi?id=117938
<rdar://problem/14246763>

Reviewed by Jer Noble.

This is timing dependent and I was unable to come up with a reliable test.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element

has been cleared.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r151914 r151916  
     12013-06-24  Eric Carlson  <eric.carlson@apple.com>
     2
     3        Potential crash when in-band track is removed
     4        https://bugs.webkit.org/show_bug.cgi?id=117938
     5        <rdar://problem/14246763>
     6
     7        Reviewed by Jer Noble.
     8
     9        This is timing dependent and I was unable to come up with a reliable test.
     10
     11        * html/track/InbandTextTrack.cpp:
     12        (WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element
     13            has been cleared.
     14
    1152013-06-24  Chris Rogers  <crogers@google.com>
    216
  • trunk/Source/WebCore/html/track/InbandTextTrack.cpp

    r151697 r151916  
    278278void InbandTextTrack::willRemoveTextTrackPrivate(InbandTextTrackPrivate* trackPrivate)
    279279{
     280    if (!mediaElement())
     281        return;
     282
    280283    UNUSED_PARAM(trackPrivate);
    281284    ASSERT(trackPrivate == m_private);
Note: See TracChangeset for help on using the changeset viewer.