Changeset 152198 in webkit

Timestamp:

Jun 28, 2013 5:09:09 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

An element with -webkit-user-select: all should be selected on single click
​https://bugs.webkit.org/show_bug.cgi?id=117864

Reviewed by Darin Adler.

Source/WebCore:

Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.

Test: editing/selection/user-select-all-with-single-click.html

• page/EventHandler.cpp:

(WebCore::canMouseDownStartSelect):

LayoutTests:

Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.

• editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
• editing/selection/user-select-all-with-image-single-click.html: Added.
• editing/selection/user-select-all-with-single-click-expected.txt: Added.
• editing/selection/user-select-all-with-single-click.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/user-select-all-image-with-single-click-expected.txt (added)
• LayoutTests/editing/selection/user-select-all-image-with-single-click.html (added)
• LayoutTests/editing/selection/user-select-all-with-single-click-expected.txt (added)
• LayoutTests/editing/selection/user-select-all-with-single-click.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Position.h (modified) (1 diff)
• Source/WebCore/page/EventHandler.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-06-28  Ryosuke Niwa  <rniwa@webkit.org>
+
+        An element with -webkit-user-select: all should be selected on single click
+        https://bugs.webkit.org/show_bug.cgi?id=117864
+
+        Reviewed by Darin Adler.
+
+        Add tests for single clicking on an element with user-select: all.
+        We select the entire element regardless of whether the user had clicked on text or an image
+        to be consistent even though Firefox requires a double click on the latter case.
+
+        * editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
+        * editing/selection/user-select-all-with-image-single-click.html: Added.
+        * editing/selection/user-select-all-with-single-click-expected.txt: Added.
+        * editing/selection/user-select-all-with-single-click.html: Added.
+
 2013-06-28  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-28  Ryosuke Niwa  <rniwa@webkit.org>
+
+        An element with -webkit-user-select: all should be selected on single click
+        https://bugs.webkit.org/show_bug.cgi?id=117864
+
+        Reviewed by Darin Adler.
+
+        Set m_mouseDownMayStartSelect true even when the node cannot start selection
+        if the node was inside an element with -webkit-user-select: all.
+
+        Test: editing/selection/user-select-all-with-single-click.html
+
+        * page/EventHandler.cpp:
+        (WebCore::canMouseDownStartSelect):
+
 2013-06-28  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/dom/Position.h

@@ -192 +192 @@
     static bool nodeIsUserSelectAll(const Node*);
     static Node* rootUserSelectAllForNode(Node*);
+#else
+    static bool nodeIsUserSelectAll(const Node*) { return false; }
+    static Node* rootUserSelectAllForNode(Node*) { return 0; }
 #endif
     static ContainerNode* findParent(const Node*);

trunk/Source/WebCore/page/EventHandler.cpp

@@ -641 +641 @@
         return true;
 
-    if (!node->canStartSelection())
-        return false;
-
-    return true;
+    return node->canStartSelection() || Position::nodeIsUserSelectAll(node);
 }