Changeset 152298 in webkit

Timestamp:

Jul 2, 2013 9:50:49 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[ATK] Leak: leaks in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::stringValue):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-07-02  Brian Holt  <brian.holt@samsung.com>
+
+        [ATK] Leak: leaks in AccessibilityUIElement
+        https://bugs.webkit.org/show_bug.cgi?id=118297
+
+        Fixed memory leak.
+
+        Reviewed by Christophe Dumez.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        (AccessibilityUIElement::stringValue):
+
 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
 

trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp

@@ -421 +421 @@
         return JSStringCreateWithCharacters(0, 0);
 
-    gchar* text = atk_text_get_text(ATK_TEXT(m_element), 0, -1);
-    GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", replaceCharactersForResults(text)));
-    g_free(text);
+    GOwnPtr<gchar> text(atk_text_get_text(ATK_TEXT(m_element), 0, -1));
+    GOwnPtr<gchar> textWithReplacedCharacters(replaceCharactersForResults(text.get()));
+    GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", textWithReplacedCharacters.get()));
 
     return JSStringCreateWithUTF8CString(axValue.get());