Changeset 152348 in webkit

Timestamp:

Jul 3, 2013 3:13:34 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

H&R Block 2010 Help window can not be reopened.
​https://bugs.webkit.org/show_bug.cgi?id=118342

Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-03
Reviewed by Antti Koivisto.

​http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.

Source/WebCore:

• WebCore.exp.in:
• platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsHRBlock):

• platform/RuntimeApplicationChecks.h:

Source/WebKit/mac:

• WebView/WebView.mm:

(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.cpp (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebView.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-03  Zalan Bujtas  <zalan@apple.com>
+
+        H&R Block 2010 Help window can not be reopened.
+        https://bugs.webkit.org/show_bug.cgi?id=118342
+
+        Reviewed by Antti Koivisto.
+
+        http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
+        only the opener can (re)focus() a particular window.
+        H&R Block app relies on the relaxed window.focus() rules.
+
+        * WebCore.exp.in:
+        * platform/RuntimeApplicationChecks.cpp:
+        (WebCore::applicationIsHRBlock):
+        * platform/RuntimeApplicationChecks.h:
+
 2013-07-03  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -1844 +1844 @@
 __ZN7WebCore20PlatformEventFactory27createPlatformKeyboardEventEP7NSEvent
 __ZN7WebCore20builtInPDFPluginNameEv
+__ZN7WebCore20applicationIsHRBlockEv
 __ZN7WebCore21DeviceOrientationData6createEbdbdbdbb
 __ZN7WebCore21applicationIsApertureEv

trunk/Source/WebCore/platform/RuntimeApplicationChecks.cpp

@@ -109 +109 @@
 }
 
+bool applicationIsHRBlock()
+{
+    static bool isHRBlock = mainBundleIsEqualTo("com.hrblock.tax.2010");
+    return isHRBlock;
+}
+
 bool applicationIsSolidStateNetworksDownloader()
 {

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -39 +39 @@
 bool applicationIsSolidStateNetworksDownloader();
 bool applicationIsVersions();
+bool applicationIsHRBlock();
 
 } // namespace WebCore

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2013-07-03  Zalan Bujtas  <zalan@apple.com>
+
+        H&R Block 2010 Help window can not be reopened.
+        https://bugs.webkit.org/show_bug.cgi?id=118342
+
+        Reviewed by Antti Koivisto.
+
+        http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
+        only the opener can (re)focus() a particular window.
+        H&R Block app relies on the relaxed window.focus() rules.
+
+        * WebView/WebView.mm:
+        (shouldRestrictWindowFocus):
+        (-[WebView _preferencesChanged:]):
+
 2013-07-01  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -624 +624 @@
 }
 
+static bool shouldRestrictWindowFocus()
+{
+    return !applicationIsHRBlock();
+}
+
 - (void)_dispatchPendingLoadRequests
 {
@@ -1500 +1505 @@
     settings->setAccelerated2dCanvasEnabled([preferences accelerated2dCanvasEnabled]);
     settings->setLoadDeferringEnabled(shouldEnableLoadDeferring());
+    settings->setWindowFocusRestricted(shouldRestrictWindowFocus());
     settings->setFrameFlatteningEnabled([preferences isFrameFlatteningEnabled]);
     settings->setSpatialNavigationEnabled([preferences isSpatialNavigationEnabled]);