Changeset 152407 in webkit

Timestamp:

Jul 4, 2013 2:17:40 PM (11 years ago)

Author:

andersca@apple.com

Message:

Paint the page background if we haven't received our first update
​https://bugs.webkit.org/show_bug.cgi?id=118402
<rdar://problem/13893308>

Reviewed by Simon Fraser.

Make sure that we always paint something when we haven't received our first update from the web process.

• UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):

• UIProcess/DrawingAreaProxyImpl.h:

(WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)
• UIProcess/DrawingAreaProxyImpl.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-07-04  Anders Carlsson  <andersca@apple.com>
+
+        Paint the page background if we haven't received our first update
+        https://bugs.webkit.org/show_bug.cgi?id=118402
+        <rdar://problem/13893308>
+
+        Reviewed by Simon Fraser.
+
+        Make sure that we always paint something when we haven't received our first update from the web process.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView drawRect:]):
+        * UIProcess/DrawingAreaProxyImpl.h:
+        (WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):
+
 2013-07-04  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -2166 +2166 @@
             // If the window doesn't have a valid backing store, we need to fill the parts of the page that we
             // didn't paint with the background color (white or clear), to avoid garbage in those areas.
-            if (!_data->_windowHasValidBackingStore) {
+            if (!_data->_windowHasValidBackingStore || !drawingArea->hasReceivedFirstUpdate()) {
                 Vector<IntRect> unpaintedRects = unpaintedRegion.rects();
                 for (size_t i = 0; i < unpaintedRects.size(); ++i)

trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h

@@ -52 +52 @@
     bool isInAcceleratedCompositingMode() const { return !m_layerTreeContext.isEmpty(); }
 #endif
+
+    bool hasReceivedFirstUpdate() const { return m_hasReceivedFirstUpdate; }
 
 private: