Changeset 152599 in webkit
- Timestamp:
- Jul 12, 2013 11:36:25 AM (11 years ago)
- Location:
- trunk/Tools
- Files:
-
- 1 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r152596 r152599 1 2013-07-12 Brian Holt <brian.holt@samsung.com> 2 3 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member 4 https://bugs.webkit.org/show_bug.cgi?id=118592 5 6 Reviewed by Martin Robinson. 7 8 Added a suppression for pylint false positives and a unit test. 9 10 * Scripts/webkitpy/style/checkers/python.py: 11 (Pylinter): 12 * Scripts/webkitpy/style/checkers/python_unittest.py: 13 (PythonCheckerTest.test_check): 14 (PythonCheckerTest): 15 (PythonCheckerTest.test_pylint_false_positives): 16 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives): 17 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added. 18 (test_popen): 19 1 20 2013-07-11 Arnaud Renevier <a.renevier@samsung.com> 2 21 -
trunk/Tools/Scripts/webkitpy/style/checkers/python.py
r134701 r152599 96 96 "Instance of 'Popen' has no 'stderr' member", 97 97 "Instance of 'Popen' has no 'wait' member", 98 "Instance of 'Popen' has no 'pid' member", 98 99 ] 99 100 -
trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest.py
r140510 r152599 62 62 (4, "pylint/E0602", 5, "Undefined variable 'error'"), 63 63 ]) 64 65 def test_pylint_false_positives(self): 66 """Test that pylint false positives are suppressed.""" 67 errors = [] 68 69 def _mock_handle_pylint_false_positives(line_number, category, confidence, 70 message): 71 error = (line_number, category, confidence, message) 72 errors.append(error) 73 74 current_dir = os.path.dirname(__file__) 75 file_path = os.path.join(current_dir, "python_unittest_false_positives.py") 76 77 checker = PythonChecker(file_path, _mock_handle_style_error) 78 checker.check(lines=[]) 79 80 self.assertEqual(errors, [])
Note: See TracChangeset
for help on using the changeset viewer.