Changeset 152836 in webkit


Ignore:
Timestamp:
Jul 18, 2013 1:04:30 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:
ASSERTION FAILED: !listItems().size()
m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection

​https://bugs.webkit.org/show_bug.cgi?id=118591

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-07-18
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/select/selectall-command-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectAll):
We should return this function if activeSelectionAnchorIndex is not valid index

LayoutTests:

  • fast/forms/select/selectall-command-crash-expected.txt: Added.
  • fast/forms/select/selectall-command-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r152834 r152836  
     12013-07-18  Santosh Mahto  <santosh.ma@samsung.com>
     2
     3        ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
     4        https://bugs.webkit.org/show_bug.cgi?id=118591
     5
     6        Reviewed by Kent Tamura.
     7
     8        * fast/forms/select/selectall-command-crash-expected.txt: Added.
     9        * fast/forms/select/selectall-command-crash.html: Added.
     10
    1112013-07-18  Ryuan Choi  <ryuan.choi@samsung.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r152834 r152836  
     12013-07-18  Santosh Mahto  <santosh.ma@samsung.com>
     2
     3        ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
     4        https://bugs.webkit.org/show_bug.cgi?id=118591
     5
     6        Reviewed by Kent Tamura.
     7
     8        Test: fast/forms/select/selectall-command-crash.html
     9
     10        * html/HTMLSelectElement.cpp:
     11        (WebCore::HTMLSelectElement::selectAll):
     12        We should return this function if activeSelectionAnchorIndex is not valid index
     13
    1142013-07-18  Ryuan Choi  <ryuan.choi@samsung.com>
    215

  • trunk/Source/WebCore/html/HTMLSelectElement.cpp

    r152330 r152836  
    568568    setActiveSelectionAnchorIndex(nextSelectableListIndex(-1));
    569569    setActiveSelectionEndIndex(previousSelectableListIndex(-1));
     570    if (m_activeSelectionAnchorIndex < 0)
     571        return;
    570572
    571573    updateListBoxSelection(false);
Note: See TracChangeset for help on using the changeset viewer.