Changeset 152907 in webkit

Timestamp:

Jul 19, 2013 10:47:36 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Hover doesn't work for block elements inside a href element
​https://bugs.webkit.org/show_bug.cgi?id=118907

Patch by Radu Stavila <​stavila@adobe.com> on 2013-07-19
Reviewed by David Hyatt.

Source/WebCore:

Added test for hovering block elements inside a href element.

Test: fast/css/hover-display-block.html

• rendering/RenderObject.cpp:

(WebCore::RenderObject::hoverAncestor):

LayoutTests:

Don't skip all anonymous objects when searching for the hover ancestor, only the ones
directly flowed into a region.

• fast/css/hover-display-block-expected.txt: Added.
• fast/css/hover-display-block.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/hover-display-block-expected.txt (added)
• LayoutTests/fast/css/hover-display-block.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-07-19  Radu Stavila  <stavila@adobe.com>
+
+        Hover doesn't work for block elements inside a href element
+        https://bugs.webkit.org/show_bug.cgi?id=118907
+
+        Reviewed by David Hyatt.
+
+        Don't skip all anonymous objects when searching for the hover ancestor, only the ones
+        directly flowed into a region.
+
+        * fast/css/hover-display-block-expected.txt: Added.
+        * fast/css/hover-display-block.html: Added.
+
 2013-07-19  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-19  Radu Stavila  <stavila@adobe.com>
+
+        Hover doesn't work for block elements inside a href element
+        https://bugs.webkit.org/show_bug.cgi?id=118907
+
+        Reviewed by David Hyatt.
+
+        Added test for hovering block elements inside a href element.
+
+        Test: fast/css/hover-display-block.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::hoverAncestor):
+
 2013-07-19  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -3051 +3051 @@
     RenderObject* hoverAncestor = parent();
     
-    // Skip anonymous blocks. There's no point in treating them as hover ancestors
-    // and it would also prevent us from continuing the search on the DOM tree
-    // when reaching the named flow thread.
-    if (hoverAncestor && hoverAncestor->isAnonymousBlock())
+    // Skip anonymous blocks directly flowed into flow threads as it would
+    // prevent us from continuing the search on the DOM tree when reaching the named flow thread.
+    if (hoverAncestor && hoverAncestor->isAnonymousBlock() && hoverAncestor->parent() && hoverAncestor->parent()->isRenderNamedFlowThread())
         hoverAncestor = hoverAncestor->parent();