Changeset 153727 in webkit
- Timestamp:
- Aug 5, 2013 3:11:04 PM (11 years ago)
- Location:
- branches/safari-537-branch
- Files:
-
- 4 edited
- 2 copied
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-537-branch/LayoutTests/ChangeLog
r153708 r153727 1 2013-08-05 Lucas Forschler <lforschler@apple.com> 2 3 Merge r153725 4 5 2013-08-05 Alexey Proskuryakov <ap@apple.com> 6 7 <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way 8 of text when dictating an e-mail 9 https://bugs.webkit.org/show_bug.cgi?id=119496 10 11 Reviewed by Ryosuke Niwa. 12 13 * platform/mac/editing/input/firstrectforcharacterrange-caret-in-br-expected.txt: Added. 14 * platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html: Added. 15 16 * platform/wk2/TestExpectations: textInputController.firstRectForCharacterRange is 17 not available in WTR. 18 1 19 2013-08-05 Filip Pizlo <fpizlo@apple.com> 2 20 -
branches/safari-537-branch/LayoutTests/platform/wk2/TestExpectations
r153066 r153727 126 126 platform/mac/editing/input/bold-node.html 127 127 platform/mac/editing/input/caret-primary-bidi.html 128 platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html 128 129 platform/mac/editing/input/firstrectforcharacterrange-plain.html 129 130 platform/mac/editing/input/firstrectforcharacterrange-styled.html -
branches/safari-537-branch/Source/WebCore/ChangeLog
r153719 r153727 1 2013-08-05 Lucas Forschler <lforschler@apple.com> 2 3 Merge r153725 4 5 2013-08-05 Alexey Proskuryakov <ap@apple.com> 6 7 <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way 8 of text when dictating an e-mail 9 https://bugs.webkit.org/show_bug.cgi?id=119496 10 11 Reviewed by Ryosuke Niwa. 12 13 Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html 14 15 * rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange): 16 FloatRect::unite() doesn't preserve empty rects, which we need here. 17 We alrady handle the case of collapsed range in Editor::firstRectForRange(), and 18 this is similar, but we can't currently cover both with one simple fix. 19 1 20 2013-08-05 Lucas Forschler <lforschler@apple.com> 2 21 -
branches/safari-537-branch/Source/WebCore/rendering/RenderObject.cpp
r153598 r153727 1240 1240 range->textQuads(quads); 1241 1241 1242 FloatRect result; 1243 for (size_t i = 0; i < quads.size(); ++i) 1244 result.unite(quads[i].boundingBox()); 1242 if (quads.isEmpty()) 1243 return FloatRect(); 1244 1245 FloatRect result = quads[0].boundingBox(); 1246 for (size_t i = 1; i < quads.size(); ++i) 1247 result.uniteEvenIfEmpty(quads[i].boundingBox()); 1245 1248 1246 1249 return result;
Note: See TracChangeset
for help on using the changeset viewer.