Changeset 154012 in webkit

Timestamp:

Aug 13, 2013 10:58:53 AM (11 years ago)

Author:

Christophe Dumez

Message:

NodeList.item() does not behave according to specification
​https://bugs.webkit.org/show_bug.cgi?id=119722

Reviewed by Darin Adler.

Source/WebCore:

Make NodeList.item() indexed getter behave according to specification:
​http://dom.spec.whatwg.org/#nodelist

Namely, we no longer throw if the index is negative (meaning the
[IsIndex] extended attribute is dropped) and the argument is now
mandatory.

This behavior is consistent with both IE10 and Firefox and since
recently Blink.

Test: fast/dom/nodelist-item-parameter.html

• dom/NodeList.idl:

LayoutTests:

Add a layout test to check that the NodeList.item() indexed getter's
argument is properly validated. Also, update the following test case now
that the argument is mandatory:
fast/dom/non-numeric-values-numeric-parameters.html

• fast/dom/nodelist-item-parameter-expected.txt: Added.
• fast/dom/nodelist-item-parameter.html: Added.
• fast/dom/non-numeric-values-numeric-parameters-expected.txt:
• fast/dom/script-tests/non-numeric-values-numeric-parameters.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/nodelist-item-parameter-expected.txt (added)
• LayoutTests/fast/dom/nodelist-item-parameter.html (added)
• LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (modified) (1 diff)
• LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/NodeList.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        NodeList.item() does not behave according to specification
+        https://bugs.webkit.org/show_bug.cgi?id=119722
+
+        Reviewed by Darin Adler.
+
+        Add a layout test to check that the NodeList.item() indexed getter's
+        argument is properly validated. Also, update the following test case now
+        that the argument is mandatory:
+        fast/dom/non-numeric-values-numeric-parameters.html
+
+        * fast/dom/nodelist-item-parameter-expected.txt: Added.
+        * fast/dom/nodelist-item-parameter.html: Added.
+        * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+        * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+
 2013-08-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 

trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt

@@ -51 +51 @@
 PASS nonNumericPolicy('document.body.attributes.item(x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createNodeIterator(document, x, null, false)') is 'any type allowed'
-PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed'
+PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed (but not omitted)'
 PASS nonNumericPolicy('document.createRange().setStart(document, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().setEnd(document, x)') is 'any type allowed'

trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

@@ -300 +300 @@
 // NodeList
 
-shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed'");
+shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed (but not omitted)'");
 
 // Range

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        NodeList.item() does not behave according to specification
+        https://bugs.webkit.org/show_bug.cgi?id=119722
+
+        Reviewed by Darin Adler.
+
+        Make NodeList.item() indexed getter behave according to specification:
+        http://dom.spec.whatwg.org/#nodelist
+
+        Namely, we no longer throw if the index is negative (meaning the
+        [IsIndex] extended attribute is dropped) and the argument is now
+        mandatory.
+
+        This behavior is consistent with both IE10 and Firefox and since
+        recently Blink.
+
+        Test: fast/dom/nodelist-item-parameter.html
+
+        * dom/NodeList.idl:
+
 2013-08-13  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/dom/NodeList.idl

@@ -24 +24 @@
 ] interface NodeList {
 
-    getter Node item([IsIndex,Default=Undefined] optional unsigned long index);
+    getter Node item(unsigned long index);
     getter (Node or unsigned long) (DOMString name);