Changeset 154018 in webkit

Timestamp:

Aug 13, 2013, 1:18:30 PM (13 years ago)

Author:

Simon Fraser

Message:

Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent();
​https://bugs.webkit.org/show_bug.cgi?id=119551

Reviewed by Dean Jackson.

Only re-parent the flattening layer if we had to update our
layer configuration (reparenting is necessary then to get
the correct sibling ordering), or if it was parented in some
other layer.

This avoid unnecessary flushing of state to CA.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-13  Simon Fraser  <simon.fraser@apple.com>
+
+        Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent();
+        https://bugs.webkit.org/show_bug.cgi?id=119551
+
+        Reviewed by Dean Jackson.
+
+        Only re-parent the flattening layer if we had to update our
+        layer configuration (reparenting is necessary then to get
+        the correct sibling ordering), or if it was parented in some
+        other layer.
+        
+        This avoid unnecessary flushing of state to CA.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
+
 2013-08-13  Robert Hogan  <robert@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -540 +540 @@
 
     if (GraphicsLayer* flatteningLayer = tileCacheFlatteningLayer()) {
-        flatteningLayer->removeFromParent();
-        m_graphicsLayer->addChild(flatteningLayer);
+        if (layerConfigChanged || flatteningLayer->parent() != m_graphicsLayer)
+            m_graphicsLayer->addChild(flatteningLayer);
     }