Changeset 154022 in webkit

Timestamp:

Aug 13, 2013 2:12:21 PM (11 years ago)

Author:

dino@apple.com

Message:

<​https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog

Reviewed by Mark Rowe.

Have prepare-ChangeLog produce webkit.org/b/id style
URLs rather than exposing the inner workings of our
cgi. I was going to use the term "Future Proofing"
but that seems excessive :)

• Scripts/prepare-ChangeLog:

(main): Generate a more human readable form.
(generateNewChangeLogs): Use it when printing out the ChangeLog entry.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (6 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-08-13  Dean Jackson  <dino@apple.com>
+
+        <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
+
+        Reviewed by Mark Rowe.
+
+        Have prepare-ChangeLog produce webkit.org/b/id style
+        URLs rather than exposing the inner workings of our
+        cgi. I was going to use the term "Future Proofing"
+        but that seems excessive :)
+
+        * Scripts/prepare-ChangeLog:
+        (main): Generate a more human readable form.
+        (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
+
 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 

trunk/Tools/Scripts/prepare-ChangeLog

@@ -22 +22 @@
 #  Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 #
-
 
 # Perl script to create a ChangeLog entry with names of files
@@ -80 +79 @@
 sub generateFileList(\%$$$);
 sub generateFunctionLists($$$$$);
-sub generateNewChangeLogs($$$$$$$$$$$);
+sub generateNewChangeLogs($$$$$$$$$$$$);
 sub getLatestChangeLogs($);
 sub get_function_line_ranges($$);
@@ -196 +195 @@
 
     my $bugURL;
+    my $readableBugURL;
     if ($bugNumber) {
         $bugURL = "https://bugs.webkit.org/show_bug.cgi?id=$bugNumber";
+        $readableBugURL = "https://webkit.org/b/$bugNumber";
     }
 
@@ -213 +214 @@
     }
 
-    generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs);
+    generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $readableBugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs);
 
     if ($writeChangeLogs) {
@@ -460 +461 @@
 }
 
-sub generateNewChangeLogs($$$$$$$$$$$)
-{
-    my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs) = @_;
+sub generateNewChangeLogs($$$$$$$$$$$$)
+{
+    my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $readableBugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs) = @_;
 
     # Generate new ChangeLog entries and (optionally) write out new ChangeLog files.
@@ -496 +497 @@
         print CHANGE_LOG normalizeLineEndings($description . "\n", $endl) if $description;
 
-        $bugDescription = "Need a short description (OOPS!).\n        Need the bug URL (OOPS!)." unless $bugDescription;
-        print CHANGE_LOG normalizeLineEndings("        $bugDescription\n", $endl) if $bugDescription;
-        print CHANGE_LOG normalizeLineEndings("        $bugURL\n", $endl) if $bugURL;
+        $bugDescription = "Need a short description (OOPS!)" unless $bugDescription;
+        $readableBugURL = "Need the bug URL (OOPS!)" unless $readableBugURL;
+        print CHANGE_LOG normalizeLineEndings("        <$readableBugURL> $bugDescription\n", $endl);
         print CHANGE_LOG normalizeLineEndings("\n", $endl);