Changeset 154246 in webkit

Timestamp:

Aug 18, 2013 4:06:35 AM (11 years ago)

Author:

Antti Koivisto

Message:

<​https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement

Reviewed by Andreas Kling.

As a follow-up, mark as crashing a test that is now expected to crash in controlled manner (CRASH()).

Note that the test only ever passed because the amount of data was huge enough (>4GB) for it to take
the special do-nothing code path. With slightly less data the test would hit CRASH() in fastRealloc() like
it does now.

• TestExpectations:

Mark fast/css/giant-stylesheet-crash.html as crashing.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-18  Antti Koivisto  <antti@apple.com>
+
+        <https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement
+
+        Reviewed by Andreas Kling.
+        
+        As a follow-up, mark as crashing a test that is now expected to crash in controlled manner (CRASH()).
+
+        Note that the test only ever passed because the amount of data was huge enough (>4GB) for it to take
+        the special do-nothing code path. With slightly less data the test would hit CRASH() in fastRealloc() like
+        it does now.
+
+        * TestExpectations:
+        
+            Mark fast/css/giant-stylesheet-crash.html as crashing.
+
 2013-08-17  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -35 +35 @@
 
 webkit.org/b/119094 fast/forms/color/input-color-onchange-event.html [ Crash Pass ]
+
+# This is an expected controlled crash. See webkit.org/b/119976 for a better solution.
+fast/css/giant-stylesheet-crash.html [ Crash ]