Changeset 154323 in webkit

Timestamp:

Aug 20, 2013 5:47:57 AM (11 years ago)

Author:

Antti Koivisto

Message:

<​https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing

Source/WebCore:

Reviewed by Andreas Kling.

• xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.

LayoutTests:

Reviewed by by Andreas Kling.

• TestExpectations: Unskip.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/XMLErrors.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-20  Antti Koivisto  <antti@apple.com>
+
+        <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
+
+        Reviewed by by Andreas Kling.
+
+        * TestExpectations: Unskip.
+
 2013-08-20  Antti Koivisto  <antti@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -36 +36 @@
 webkit.org/b/119094 fast/forms/color/input-color-onchange-event.html [ Crash Pass ]
 
-webkit.org/b/120023 svg/custom/bug78807.svg [ Failure ]
-webkit.org/b/120023 svg/custom/use-invalid-style.svg [ Failure ]
-
 # This is an expected controlled crash. See webkit.org/b/119976 for a better solution.
 fast/css/giant-stylesheet-crash.html [ Crash ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-20  Antti Koivisto  <antti@apple.com>
+
+        <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
+
+        Reviewed by Andreas Kling.
+
+        * xml/XMLErrors.cpp:
+        (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.
+
 2013-08-20  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/xml/XMLErrors.cpp

@@ -148 +148 @@
             // In general, rootElement shouldn't be attached right now, but it will be if there is a style element
             // in the SVG content.
-            Style::detachRenderTree(rootElement.get());
+            Style::reattachRenderTree(rootElement.get());
 
         documentElement = body.get();