Changeset 154455 in webkit

Timestamp:

Aug 22, 2013 11:48:22 AM (11 years ago)

Author:

Simon Fraser

Message:

Reloading this video test shows garbage briefly
​https://bugs.webkit.org/show_bug.cgi?id=119377

Reviewed by Anders Carlson.

RenderVideo should not claim that it's foreground is opaque
unless it has a video frame to display.

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderVideo.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-21  Simon Fraser  <simon.fraser@apple.com>
+
+        Reloading this video test shows garbage briefly
+        https://bugs.webkit.org/show_bug.cgi?id=119377
+
+        Reviewed by Anders Carlson.
+
+        RenderVideo should not claim that it's foreground is opaque
+        unless it has a video frame to display.
+
+        * rendering/RenderVideo.cpp:
+        (WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect):
+
 2013-08-22  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/rendering/RenderVideo.cpp

@@ -344 +344 @@
         return RenderImage::foregroundIsKnownToBeOpaqueInRect(localRect, maxDepthToTest);
 
-    return videoBox().contains(enclosingIntRect(localRect));
+    if (!videoBox().contains(enclosingIntRect(localRect)))
+        return false;
+
+    if (MediaPlayer* player = mediaElement()->player())
+        return player->hasAvailableVideoFrame();
+
+    return false;
 }