Changeset 154835 in webkit


Ignore:
Timestamp:
Aug 29, 2013 1:06:33 PM (11 years ago)
Author:
Antti Koivisto
Message:

Remove code behind ENABLE(DIALOG_ELEMENT)
​https://bugs.webkit.org/show_bug.cgi?id=120467

Reviewed by Darin Adler.

It is incomplete and no one is building it.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/html.css:
  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::removedFrom):
(WebCore::Element::setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries):

  • dom/Element.h:

(WebCore::Element::isDisabledFormControl):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):

  • html/HTMLDialogElement.cpp: Removed.
  • html/HTMLDialogElement.h: Removed.
  • html/HTMLDialogElement.idl: Removed.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • rendering/RenderDialog.cpp: Removed.
  • rendering/RenderDialog.h: Removed.
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isCounter):

  • rendering/RenderingAllInOne.cpp:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
Location:
trunk/Source/WebCore
Files:
5 deleted
29 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r154809 r154835  
    430430    html/HTMLDataListElement.idl
    431431    html/HTMLDetailsElement.idl
    432     html/HTMLDialogElement.idl
    433432    html/HTMLDirectoryElement.idl
    434433    html/HTMLDivElement.idl
    … …  
    13731372    html/HTMLDataListElement.cpp
    13741373    html/HTMLDetailsElement.cpp
    1375     html/HTMLDialogElement.cpp
    13761374    html/HTMLDirectoryElement.cpp
    13771375    html/HTMLDivElement.cpp
    … …  
    21202118    rendering/RenderDeprecatedFlexibleBox.cpp
    21212119    rendering/RenderDetailsMarker.cpp
    2122     rendering/RenderDialog.cpp
    21232120    rendering/RenderEmbeddedObject.cpp
    21242121    rendering/RenderFieldset.cpp

  • trunk/Source/WebCore/ChangeLog

    r154832 r154835  
     12013-08-29  Antti Koivisto  <antti@apple.com>
     2
     3        Remove code behind ENABLE(DIALOG_ELEMENT)
     4        https://bugs.webkit.org/show_bug.cgi?id=120467
     5
     6        Reviewed by Darin Adler.
     7
     8        It is incomplete and no one is building it.
     9
     10        * CMakeLists.txt:
     11        * Configurations/FeatureDefines.xcconfig:
     12        * DerivedSources.make:
     13        * DerivedSources.pri:
     14        * GNUmakefile.list.am:
     15        * Target.pri:
     16        * WebCore.exp.in:
     17        * WebCore.xcodeproj/project.pbxproj:
     18        * bindings/generic/RuntimeEnabledFeatures.cpp:
     19        * bindings/generic/RuntimeEnabledFeatures.h:
     20        * css/StyleResolver.cpp:
     21        (WebCore::StyleResolver::adjustRenderStyle):
     22        * css/html.css:
     23        * dom/ContextFeatures.cpp:
     24        * dom/ContextFeatures.h:
     25        * dom/Document.cpp:
     26        * dom/Document.h:
     27        * dom/Element.cpp:
     28        (WebCore::Element::removedFrom):
     29        (WebCore::Element::setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries):
     30        * dom/Element.h:
     31        (WebCore::Element::isDisabledFormControl):
     32        * dom/ElementRareData.h:
     33        (WebCore::ElementRareData::ElementRareData):
     34        * html/HTMLDialogElement.cpp: Removed.
     35        * html/HTMLDialogElement.h: Removed.
     36        * html/HTMLDialogElement.idl: Removed.
     37        * html/HTMLElementsAllInOne.cpp:
     38        * html/HTMLTagNames.in:
     39        * rendering/RenderDialog.cpp: Removed.
     40        * rendering/RenderDialog.h: Removed.
     41        * rendering/RenderLayer.cpp:
     42        (WebCore::RenderLayer::rebuildZOrderLists):
     43        (WebCore::RenderLayer::collectLayers):
     44        * rendering/RenderLayer.h:
     45        * rendering/RenderObject.h:
     46        (WebCore::RenderObject::isCounter):
     47        * rendering/RenderingAllInOne.cpp:
     48        * testing/InternalSettings.cpp:
     49        (WebCore::InternalSettings::Backup::Backup):
     50        (WebCore::InternalSettings::Backup::restoreTo):
     51        * testing/InternalSettings.h:
     52
    1532013-08-29  Simon Fraser  <simon.fraser@apple.com>
    254

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r153772 r154835  
    7070ENABLE_DEVICE_ORIENTATION_iphoneos = ENABLE_DEVICE_ORIENTATION;
    7171ENABLE_DEVICE_ORIENTATION_iphonesimulator = $(ENABLE_DEVICE_ORIENTATION_iphoneos);
    72 ENABLE_DIALOG_ELEMENT = ;
    7372ENABLE_DIRECTORY_UPLOAD = ;
    7473ENABLE_DOM4_EVENTS_CONSTRUCTOR = ENABLE_DOM4_EVENTS_CONSTRUCTOR;
    … …  
    188187ENABLE_FTL_JIT = ;
    189188
    190 FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_BLOB) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CANVAS_PATH) $(ENABLE_CANVAS_PROXY) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CSP_NEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_REGIONS) $(ENABLE_CSS_SHADERS) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_SHAPES) $(ENABLE_CSS_STICKY_POSITION) $(ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED) $(ENABLE_CSS_VARIABLES) $(ENABLE_CSS3_CONDITIONAL_RULES) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS3_TEXT_LINE_BREAK) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIALOG_ELEMENT) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM4_EVENTS_CONSTRUCTOR) $(ENABLE_DRAGGABLE_REGION) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_ENCRYPTED_MEDIA_V2) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FONT_LOAD_EVENTS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING) $(ENABLE_HIGH_DPI_CANVAS) $(ENABLE_ICONDATABASE) $(ENABLE_IFRAME_SEAMLESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDIE_UI) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_NOTIFICATIONS) $(ENABLE_LEGACY_VENDOR_PREFIXES) $(ENABLE_LEGACY_WEB_AUDIO) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_PLUGIN_PROXY_FOR_VIDEO) $(ENABLE_PROGRESS_ELEMENT) $(ENABLE_PROXIMITY_EVENTS) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_SCRIPTED_SPEECH) $(ENABLE_SHADOW_DOM) $(ENABLE_SHARED_WORKERS) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_SQL_DATABASE) $(ENABLE_STYLE_SCOPED) $(ENABLE_SUBPIXEL_LAYOUT) $(ENABLE_SVG) $(ENABLE_SVG_FONTS) $(ENABLE_TEMPLATE_ELEMENT) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_THREADED_HTML_PARSER) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_USERSELECT_ALL) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIEW_MODE_CSS_MEDIA) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHR_TIMEOUT) $(ENABLE_XSLT) $(ENABLE_FTL_JIT) $(FEATURE_DEFINES_$(PLATFORM_NAME));
     189FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_BLOB) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CANVAS_PATH) $(ENABLE_CANVAS_PROXY) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CSP_NEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_REGIONS) $(ENABLE_CSS_SHADERS) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_SHAPES) $(ENABLE_CSS_STICKY_POSITION) $(ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED) $(ENABLE_CSS_VARIABLES) $(ENABLE_CSS3_CONDITIONAL_RULES) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS3_TEXT_LINE_BREAK) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM4_EVENTS_CONSTRUCTOR) $(ENABLE_DRAGGABLE_REGION) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_ENCRYPTED_MEDIA_V2) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FONT_LOAD_EVENTS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING) $(ENABLE_HIGH_DPI_CANVAS) $(ENABLE_ICONDATABASE) $(ENABLE_IFRAME_SEAMLESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDIE_UI) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_NOTIFICATIONS) $(ENABLE_LEGACY_VENDOR_PREFIXES) $(ENABLE_LEGACY_WEB_AUDIO) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_PLUGIN_PROXY_FOR_VIDEO) $(ENABLE_PROGRESS_ELEMENT) $(ENABLE_PROXIMITY_EVENTS) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_SCRIPTED_SPEECH) $(ENABLE_SHADOW_DOM) $(ENABLE_SHARED_WORKERS) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_SQL_DATABASE) $(ENABLE_STYLE_SCOPED) $(ENABLE_SUBPIXEL_LAYOUT) $(ENABLE_SVG) $(ENABLE_SVG_FONTS) $(ENABLE_TEMPLATE_ELEMENT) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_THREADED_HTML_PARSER) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_USERSELECT_ALL) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIEW_MODE_CSS_MEDIA) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHR_TIMEOUT) $(ENABLE_XSLT) $(ENABLE_FTL_JIT) $(FEATURE_DEFINES_$(PLATFORM_NAME));

  • trunk/Source/WebCore/DerivedSources.make

    r154651 r154835  
    313313    $(WebCore)/html/HTMLDataListElement.idl \
    314314    $(WebCore)/html/HTMLDetailsElement.idl \
    315     $(WebCore)/html/HTMLDialogElement.idl \
    316315    $(WebCore)/html/HTMLDirectoryElement.idl \
    317316    $(WebCore)/html/HTMLDivElement.idl \

  • trunk/Source/WebCore/DerivedSources.pri

    r154651 r154835  
    353353    $$PWD/html/HTMLDataListElement.idl \
    354354    $$PWD/html/HTMLDetailsElement.idl \
    355     $$PWD/html/HTMLDialogElement.idl \
    356355    $$PWD/html/HTMLDirectoryElement.idl \
    357356    $$PWD/html/HTMLDivElement.idl \

  • trunk/Source/WebCore/GNUmakefile.list.am

    r154809 r154835  
    43844384        Source/WebCore/rendering/RenderDetailsMarker.cpp \
    43854385        Source/WebCore/rendering/RenderDetailsMarker.h \
    4386         Source/WebCore/rendering/RenderDialog.h \
    43874386        Source/WebCore/rendering/RenderEmbeddedObject.cpp \
    43884387        Source/WebCore/rendering/RenderEmbeddedObject.h \

  • trunk/Source/WebCore/Target.pri

    r154809 r154835  
    614614    html/HTMLDListElement.cpp \
    615615    html/HTMLDataListElement.cpp \
    616     html/HTMLDialogElement.cpp \
    617616    html/HTMLDirectoryElement.cpp \
    618617    html/HTMLDetailsElement.cpp \
    … …  
    11651164    rendering/RenderDeprecatedFlexibleBox.cpp \
    11661165    rendering/RenderDetailsMarker.cpp \
    1167     rendering/RenderDialog.cpp \
    11681166    rendering/RenderEmbeddedObject.cpp \
    11691167    rendering/RenderFieldset.cpp \
    … …  
    18141812    html/HTMLCanvasElement.h \
    18151813    html/HTMLCollection.h \
    1816     html/HTMLDialogElement.h \
    18171814    html/HTMLDirectoryElement.h \
    18181815    html/HTMLDetailsElement.h \

  • trunk/Source/WebCore/WebCore.exp.in

    r154809 r154835  
    24422442#endif
    24432443
    2444 #if ENABLE(DIALOG_ELEMENT)
    2445 __ZNK7WebCore11RenderLayer12isInTopLayerEv
    2446 #endif
    2447 
    24482444#if ENABLE(DRAG_SUPPORT)
    24492445__ZN7WebCore12EventHandler17dragSourceEndedAtERKNS_18PlatformMouseEventENS_13DragOperationE
    … …  
    26862682#endif
    26872683
    2688 #if ENABLE(DIALOG_ELEMENT)
    2689 __ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE
    2690 #endif
    2691 
    26922684#if ENABLE(SVG)
    26932685__ZN7WebCore8Document13svgExtensionsEv

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r154809 r154835  
    18631863                75793ED40D0CE85B007FC0AC /* DOMMessageEvent.mm in Sources */ = {isa = PBXBuildFile; fileRef = 75793ED10D0CE85B007FC0AC /* DOMMessageEvent.mm */; };
    18641864                75793ED50D0CE85B007FC0AC /* DOMMessageEventInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 75793ED20D0CE85B007FC0AC /* DOMMessageEventInternal.h */; };
    1865                 762F1ED7159D960A007408F2 /* HTMLDialogElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 762F1ED6159D960A007408F2 /* HTMLDialogElement.h */; };
    18661865                7633A72613D8B33A008501B6 /* LocaleToScriptMapping.h in Headers */ = {isa = PBXBuildFile; fileRef = 7633A72413D8B33A008501B6 /* LocaleToScriptMapping.h */; };
    18671866                7633A72713D8B33A008501B6 /* LocaleToScriptMappingDefault.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7633A72513D8B33A008501B6 /* LocaleToScriptMappingDefault.cpp */; };
    … …  
    18771876                76CDD2F61103DA6600680521 /* AccessibilityMenuListOption.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 76CDD2F01103DA6600680521 /* AccessibilityMenuListOption.cpp */; };
    18781877                76CDD2F71103DA6600680521 /* AccessibilityMenuListOption.h in Headers */ = {isa = PBXBuildFile; fileRef = 76CDD2F11103DA6600680521 /* AccessibilityMenuListOption.h */; };
    1879                 76F2E2EC15F74CEF005FF664 /* RenderDialog.h in Headers */ = {isa = PBXBuildFile; fileRef = 76F2E2EA15F74CEF005FF664 /* RenderDialog.h */; };
    18801878                76FC2B0B12370DA0006A991A /* DOMTokenList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 76FC2B0812370DA0006A991A /* DOMTokenList.cpp */; };
    18811879                76FC2B0C12370DA0006A991A /* DOMTokenList.h in Headers */ = {isa = PBXBuildFile; fileRef = 76FC2B0912370DA0006A991A /* DOMTokenList.h */; };
    … …  
    82538251                75793ED20D0CE85B007FC0AC /* DOMMessageEventInternal.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DOMMessageEventInternal.h; sourceTree = "<group>"; };
    82548252                758978EB127090D60076D5A9 /* SpeechInputResult.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SpeechInputResult.h; sourceTree = "<group>"; };
    8255                 762F1ED6159D960A007408F2 /* HTMLDialogElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLDialogElement.h; sourceTree = "<group>"; };
    8256                 762F1ED8159D961A007408F2 /* HTMLDialogElement.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = HTMLDialogElement.idl; sourceTree = "<group>"; };
    82578253                7633A72413D8B33A008501B6 /* LocaleToScriptMapping.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LocaleToScriptMapping.h; sourceTree = "<group>"; };
    82588254                7633A72513D8B33A008501B6 /* LocaleToScriptMappingDefault.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LocaleToScriptMappingDefault.cpp; sourceTree = "<group>"; };
    … …  
    82688264                76CDD2F01103DA6600680521 /* AccessibilityMenuListOption.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibilityMenuListOption.cpp; sourceTree = "<group>"; };
    82698265                76CDD2F11103DA6600680521 /* AccessibilityMenuListOption.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityMenuListOption.h; sourceTree = "<group>"; };
    8270                 76F2E2EA15F74CEF005FF664 /* RenderDialog.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderDialog.h; sourceTree = "<group>"; };
    82718266                76FC2B0812370DA0006A991A /* DOMTokenList.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMTokenList.cpp; sourceTree = "<group>"; };
    82728267                76FC2B0912370DA0006A991A /* DOMTokenList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMTokenList.h; sourceTree = "<group>"; };
    … …  
    1574415739                                D359D787129CA2710006E5D2 /* HTMLDetailsElement.h */,
    1574515740                                D359D788129CA2710006E5D2 /* HTMLDetailsElement.idl */,
    15746                                 762F1ED6159D960A007408F2 /* HTMLDialogElement.h */,
    15747                                 762F1ED8159D961A007408F2 /* HTMLDialogElement.idl */,
    1574815741                                A8EA79ED0A1916DF00A8EF5F /* HTMLDirectoryElement.cpp */,
    1574915742                                A8EA79EE0A1916DF00A8EF5F /* HTMLDirectoryElement.h */,
    … …  
    1992219915                                D302754512A5FE84004BD828 /* RenderDetailsMarker.cpp */,
    1992319916                                D302754612A5FE84004BD828 /* RenderDetailsMarker.h */,
    19924                                 76F2E2EA15F74CEF005FF664 /* RenderDialog.h */,
    1992519917                                0F5B7A5210F65D7A00376302 /* RenderEmbeddedObject.cpp */,
    1992619918                                0F5B7A5310F65D7A00376302 /* RenderEmbeddedObject.h */,
    … …  
    2190921901                                F5C041DB0FFCA7CE00839D4A /* HTMLDataListElement.h in Headers */,
    2191021902                                D359D78A129CA2710006E5D2 /* HTMLDetailsElement.h in Headers */,
    21911                                 762F1ED7159D960A007408F2 /* HTMLDialogElement.h in Headers */,
    2191221903                                A8EA79FA0A1916DF00A8EF5F /* HTMLDirectoryElement.h in Headers */,
    2191321904                                A8EA7CB70A192B9C00A8EF5F /* HTMLDivElement.h in Headers */,
    … …  
    2303023021                                BCEA486E097D93020094C9E4 /* RenderDeprecatedFlexibleBox.h in Headers */,
    2303123022                                D302754A12A5FE84004BD828 /* RenderDetailsMarker.h in Headers */,
    23032                                 76F2E2EC15F74CEF005FF664 /* RenderDialog.h in Headers */,
    2303323023                                A76E5F7F135E0DCF00A69837 /* RenderedDocumentMarker.h in Headers */,
    2303423024                                9B32CDA913DF7FA900F34D13 /* RenderedPosition.h in Headers */,

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r151832 r154835  
    228228#endif
    229229
    230 #if ENABLE(DIALOG_ELEMENT)
    231 bool RuntimeEnabledFeatures::isDialogElementEnabled = false;
    232 #endif
    233 
    234230#if ENABLE(CSP_NEXT)
    235231bool RuntimeEnabledFeatures::areExperimentalContentSecurityPolicyFeaturesEnabled = false;

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r152083 r154835  
    277277#endif
    278278
    279 #if ENABLE(DIALOG_ELEMENT)
    280     static bool dialogElementEnabled() { return isDialogElementEnabled; }
    281     static void setDialogElementEnabled(bool isEnabled) { isDialogElementEnabled = isEnabled; }
    282 #endif
    283 
    284279#if ENABLE(CSP_NEXT)
    285280    static bool experimentalContentSecurityPolicyFeaturesEnabled() { return areExperimentalContentSecurityPolicyFeaturesEnabled; }
    … …  
    399394#endif
    400395
    401 #if ENABLE(DIALOG_ELEMENT)
    402     static bool isDialogElementEnabled;
    403 #endif
    404 
    405396#if ENABLE(CSP_NEXT)
    406397    static bool areExperimentalContentSecurityPolicyFeaturesEnabled;

  • trunk/Source/WebCore/css/StyleResolver.cpp

    r154809 r154835  
    12571257            style->setDisplay(equivalentBlockDisplay(style->display(), style->isFloating(), !document()->inQuirksMode()));
    12581258        }
    1259 
    1260 #if ENABLE(DIALOG_ELEMENT)
    1261         // Per the spec, position 'static' and 'relative' in the top layer compute to 'absolute'.
    1262         if (e && e->isInTopLayer() && (style->position() == StaticPosition || style->position() == RelativePosition)) {
    1263             style->setPosition(AbsolutePosition);
    1264             style->setDisplay(BLOCK);
    1265         }
    1266 #endif
    12671259    }
    12681260
    … …  
    12841276        || style->position() == StickyPosition
    12851277        || (style->position() == FixedPosition && e && e->document()->page() && e->document()->page()->settings().fixedPositionCreatesStackingContext())
    1286 #if ENABLE(DIALOG_ELEMENT)
    1287         || (e && e->isInTopLayer())
    1288 #endif
    12891278        ))
    12901279        style->setZIndex(0);

  • trunk/Source/WebCore/css/html.css

    r150876 r154835  
    147147}
    148148
    149 #if defined(ENABLE_DIALOG_ELEMENT) && ENABLE_DIALOG_ELEMENT
    150 dialog:not([open]) { display: none; }
    151 dialog {
    152     position: absolute;
    153     left: 0; right: 0;
    154     margin: auto;
    155     border: solid;
    156     padding: 1em;
    157     background: white;
    158     color: black;
    159 }
    160 #endif
    161 
    162149/* heading elements */
    163150

  • trunk/Source/WebCore/dom/ContextFeatures.cpp

    r154023 r154835  
    4949    static ContextFeatures* instance = ContextFeatures::create(ContextFeaturesClient::empty()).leakRef();
    5050    return instance;
    51 }
    52 
    53 bool ContextFeatures::dialogElementEnabled(Document* document)
    54 {
    55 #if ENABLE(DIALOG_ELEMENT)
    56     if (!document)
    57         return RuntimeEnabledFeatures::dialogElementEnabled();
    58     return document->contextFeatures()->isEnabled(document, DialogElement, RuntimeEnabledFeatures::dialogElementEnabled());
    59 #else
    60     UNUSED_PARAM(document);
    61     return false;
    62 #endif
    6351}
    6452

  • trunk/Source/WebCore/dom/ContextFeatures.h

    r150652 r154835  
    4040public:
    4141    enum FeatureType {
    42         DialogElement = 0,
    4342        StyleScoped,
    4443        HTMLNotifications,
    … …  
    5251    static PassRefPtr<ContextFeatures> create(ContextFeaturesClient*);
    5352
    54     static bool dialogElementEnabled(Document*);
    5553    static bool styleScopedEnabled(Document*);
    5654    static bool htmlNotificationsEnabled(Document*);

  • trunk/Source/WebCore/dom/Document.cpp

    r154766 r154835  
    54365436#endif
    54375437
    5438 #if ENABLE(DIALOG_ELEMENT)
    5439 void Document::addToTopLayer(Element* element)
    5440 {
    5441     if (element->isInTopLayer())
    5442         return;
    5443     ASSERT(!m_topLayerElements.contains(element));
    5444     m_topLayerElements.append(element);
    5445     element->setIsInTopLayer(true);
    5446 }
    5447 
    5448 void Document::removeFromTopLayer(Element* element)
    5449 {
    5450     if (!element->isInTopLayer())
    5451         return;
    5452     size_t position = m_topLayerElements.find(element);
    5453     ASSERT(position != notFound);
    5454     m_topLayerElements.remove(position);
    5455     element->setIsInTopLayer(false);
    5456 }
    5457 #endif
    5458 
    54595438#if ENABLE(POINTER_LOCK)
    54605439void Document::webkitExitPointerLock()

  • trunk/Source/WebCore/dom/Document.h

    r154766 r154835  
    11591159    Locale& getCachedLocale(const AtomicString& locale = nullAtom);
    11601160
    1161 #if ENABLE(DIALOG_ELEMENT)
    1162     void addToTopLayer(Element*);
    1163     void removeFromTopLayer(Element*);
    1164     const Vector<RefPtr<Element> >& topLayerElements() const { return m_topLayerElements; }
    1165     Element* activeModalDialog() const { return !m_topLayerElements.isEmpty() ? m_topLayerElements.last().get() : 0; }
    1166 #endif
    1167 
    11681161#if ENABLE(TEMPLATE_ELEMENT)
    11691162    const Document* templateDocument() const;
    … …  
    14831476#endif
    14841477
    1485 #if ENABLE(DIALOG_ELEMENT)
    1486     Vector<RefPtr<Element> > m_topLayerElements;
    1487 #endif
    1488 
    14891478    int m_loadEventDelayCount;
    14901479    Timer<Document> m_loadEventDelayTimer;

  • trunk/Source/WebCore/dom/Element.cpp

    r154806 r154835  
    12681268}
    12691269
    1270 bool Element::isDisabledFormControl() const
    1271 {
    1272 #if ENABLE(DIALOG_ELEMENT)
    1273     // FIXME: disabled and inert are separate concepts in the spec, but now we treat them as the same.
    1274     // For example, an inert, non-disabled form control should not be grayed out.
    1275     if (isInert())
    1276         return true;
    1277 #endif
    1278     return false;
    1279 }
    1280 
    1281 #if ENABLE(DIALOG_ELEMENT)
    1282 bool Element::isInert() const
    1283 {
    1284     Element* dialog = document()->activeModalDialog();
    1285     return dialog && !containsIncludingShadowDOM(dialog) && !dialog->containsIncludingShadowDOM(this);
    1286 }
    1287 #endif
    1288 
    12891270Node::InsertionNotificationRequest Element::insertedInto(ContainerNode* insertionPoint)
    12901271{
    … …  
    13411322#endif
    13421323
    1343 #if ENABLE(DIALOG_ELEMENT)
    1344     document()->removeFromTopLayer(this);
    1345 #endif
    13461324#if ENABLE(FULLSCREEN_API)
    13471325    if (containsFullScreenElement())
    … …  
    26112589        element->setContainsFullScreenElement(flag);
    26122590}
    2613 #endif   
    2614 
    2615 #if ENABLE(DIALOG_ELEMENT)
    2616 bool Element::isInTopLayer() const
    2617 {
    2618     return hasRareData() && elementRareData()->isInTopLayer();
    2619 }
    2620 
    2621 void Element::setIsInTopLayer(bool inTopLayer)
    2622 {
    2623     if (isInTopLayer() == inTopLayer)
    2624         return;
    2625     ensureElementRareData().setIsInTopLayer(inTopLayer);
    2626 
    2627     // We must ensure a reattach occurs so the renderer is inserted in the correct sibling order under RenderView according to its
    2628     // top layer position, or in its usual place if not in the top layer.
    2629     reattachIfAttached();
    2630 }
    26312591#endif
    26322592

  • trunk/Source/WebCore/dom/Element.h

    r154806 r154835  
    476476    // Used for disabled form elements; if true, prevents mouse events from being dispatched
    477477    // to event listeners, and prevents DOMActivate events from being sent at all.
    478     virtual bool isDisabledFormControl() const;
    479 
    480 #if ENABLE(DIALOG_ELEMENT)
    481     bool isInert() const;
    482 #endif
     478    virtual bool isDisabledFormControl() const { return false; }
     479
    483480
    484481#if ENABLE(SVG)
    … …  
    505502#endif
    506503
    507 #if ENABLE(DIALOG_ELEMENT)
    508     bool isInTopLayer() const;
    509     void setIsInTopLayer(bool);
    510 #endif
    511 
    512504#if ENABLE(POINTER_LOCK)
    513505    void webkitRequestPointerLock();

  • trunk/Source/WebCore/dom/ElementRareData.h

    r154541 r154835  
    7272    bool containsFullScreenElement() { return m_containsFullScreenElement; }
    7373    void setContainsFullScreenElement(bool value) { m_containsFullScreenElement = value; }
    74 #endif
    75 
    76 #if ENABLE(DIALOG_ELEMENT)
    77     bool isInTopLayer() const { return m_isInTopLayer; }
    78     void setIsInTopLayer(bool value) { m_isInTopLayer = value; }
    7974#endif
    8075
    … …  
    142137    unsigned m_containsFullScreenElement : 1;
    143138#endif
    144 #if ENABLE(DIALOG_ELEMENT)
    145     unsigned m_isInTopLayer : 1;
    146 #endif
    147139#if ENABLE(SVG)
    148140    unsigned m_hasPendingResources : 1;
    … …  
    195187    , m_containsFullScreenElement(false)
    196188#endif
    197 #if ENABLE(DIALOG_ELEMENT)
    198     , m_isInTopLayer(false)
    199 #endif
    200189#if ENABLE(SVG)
    201190    , m_hasPendingResources(false)

  • trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp

    r149525 r154835  
    4949#include "HTMLDetailsElement.cpp"
    5050#include "HTMLDListElement.cpp"
    51 #include "HTMLDialogElement.cpp"
    5251#include "HTMLDirectoryElement.cpp"
    5352#include "HTMLDivElement.cpp"

  • trunk/Source/WebCore/html/HTMLTagNames.in

    r152437 r154835  
    4040dfn interfaceName=HTMLElement
    4141dir interfaceName=HTMLDirectoryElement
    42 dialog conditional=DIALOG_ELEMENT, contextConditional=dialogElement
    4342div
    4443dl interfaceName=HTMLDListElement

  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r154785 r154835  
    43814381}
    43824382
    4383 #if ENABLE(DIALOG_ELEMENT)
    4384 bool RenderLayer::isInTopLayer() const
    4385 {
    4386     Node* node = renderer().node();
    4387     return node && node->isElementNode() && toElement(node)->isInTopLayer();
    4388 }
    4389 
    4390 bool RenderLayer::isInTopLayerSubtree() const
    4391 {
    4392     for (const RenderLayer* layer = this; layer; layer = layer->parent()) {
    4393         if (layer->isInTopLayer())
    4394             return true;
    4395     }
    4396     return false;
    4397 }
    4398 #endif
    4399 
    44004383// Compute the z-offset of the point in the transformState.
    44014384// This is effectively projecting a ray normal to the plane of ancestor, finding where that
    … …  
    56835666    if (negZOrderList)
    56845667        std::stable_sort(negZOrderList->begin(), negZOrderList->end(), compareZIndex);
    5685 
    5686 #if ENABLE(DIALOG_ELEMENT)
    5687     // Append layers for top layer elements after normal layer collection, to ensure they are on top regardless of z-indexes.
    5688     // The renderers of top layer elements are children of the view, sorted in top layer stacking order.
    5689     if (isRootLayer()) {
    5690         RenderObject* view = renderer().view();
    5691         for (RenderObject* child = view->firstChild(); child; child = child->nextSibling()) {
    5692             Element* childElement = (child->node() && child->node()->isElementNode()) ? toElement(child->node()) : 0;
    5693             if (childElement && childElement->isInTopLayer()) {
    5694                 RenderLayer* layer = toRenderLayerModelObject(child)->layer();
    5695                 posZOrderList->append(layer);
    5696             }
    5697         }
    5698     }
    5699 #endif
    5700 
    57015668}
    57025669
    … …  
    57225689void RenderLayer::collectLayers(bool includeHiddenLayers, CollectLayersBehavior behavior, OwnPtr<Vector<RenderLayer*> >& posBuffer, OwnPtr<Vector<RenderLayer*> >& negBuffer)
    57235690{
    5724 #if ENABLE(DIALOG_ELEMENT)
    5725     if (isInTopLayer())
    5726         return;
    5727 #endif
    5728 
    57295691    updateDescendantDependentFlags();
    57305692

  • trunk/Source/WebCore/rendering/RenderLayer.h

    r154785 r154835  
    822822    Node* enclosingElement() const;
    823823
    824 #if ENABLE(DIALOG_ELEMENT)
    825     bool isInTopLayer() const;
    826     bool isInTopLayerSubtree() const;
    827 #endif
    828 
    829824#if USE(ACCELERATED_COMPOSITING)
    830825    enum ViewportConstrainedNotCompositedReason {

  • trunk/Source/WebCore/rendering/RenderObject.h

    r154580 r154835  
    324324    virtual bool isBoxModelObject() const { return false; }
    325325    virtual bool isCounter() const { return false; }
    326 #if ENABLE(DIALOG_ELEMENT)
    327     virtual bool isDialog() const { return false; }
    328 #endif
    329326    virtual bool isQuote() const { return false; }
    330327

  • trunk/Source/WebCore/rendering/RenderingAllInOne.cpp

    r144786 r154835  
    5454#include "RenderDeprecatedFlexibleBox.cpp"
    5555#include "RenderDetailsMarker.cpp"
    56 #include "RenderDialog.cpp"
    5756#include "RenderEmbeddedObject.cpp"
    5857#include "RenderFieldset.cpp"

  • trunk/Source/WebCore/testing/InternalSettings.cpp

    r154658 r154835  
    8484#endif
    8585    , m_originalMediaTypeOverride(settings.mediaTypeOverride())
    86 #if ENABLE(DIALOG_ELEMENT)
    87     , m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnabled())
    88 #endif
    8986    , m_originalCanvasUsesAcceleratedDrawing(settings.canvasUsesAcceleratedDrawing())
    9087    , m_originalMockScrollbarsEnabled(settings.mockScrollbarsEnabled())
    … …  
    122119#endif
    123120    settings.setMediaTypeOverride(m_originalMediaTypeOverride);
    124 #if ENABLE(DIALOG_ELEMENT)
    125     RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabled);
    126 #endif
    127121    settings.setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing);
    128122    settings.setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
    … …  
    391385}
    392386
    393 void InternalSettings::setDialogElementEnabled(bool enabled, ExceptionCode& ec)
    394 {
    395     UNUSED_PARAM(ec);
    396 #if ENABLE(DIALOG_ELEMENT)
    397     RuntimeEnabledFeatures::setDialogElementEnabled(enabled);
    398 #else
    399     UNUSED_PARAM(enabled);
    400 #endif
    401 }
    402 
    403387void InternalSettings::setShouldDisplayTrackKind(const String& kind, bool enabled, ExceptionCode& ec)
    404388{

  • trunk/Source/WebCore/testing/InternalSettings.h

    r153927 r154835  
    6868#endif
    6969        String m_originalMediaTypeOverride;
    70 #if ENABLE(DIALOG_ELEMENT)
    71         bool m_originalDialogElementEnabled;
    72 #endif
    7370        bool m_originalCanvasUsesAcceleratedDrawing;
    7471        bool m_originalMockScrollbarsEnabled;
    … …  
    120117    void setCanStartMedia(bool, ExceptionCode&);
    121118    void setEditingBehavior(const String&, ExceptionCode&);
    122     void setDialogElementEnabled(bool, ExceptionCode&);
    123119    void setShouldDisplayTrackKind(const String& kind, bool enabled, ExceptionCode&);
    124120    bool shouldDisplayTrackKind(const String& kind, ExceptionCode&);

  • trunk/Source/WebCore/testing/InternalSettings.idl

    r151336 r154835  
    5050    [RaisesException] void setCanStartMedia(boolean enabled);
    5151    [RaisesException] void setEditingBehavior(DOMString behavior);
    52     [RaisesException] void setDialogElementEnabled(boolean enabled);
    5352    void setLangAttributeAwareFormControlUIEnabled(boolean enabled);
    5453
Note: See TracChangeset for help on using the changeset viewer.