Changeset 155078 in webkit

Timestamp:

Sep 4, 2013 3:55:52 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

AX: when no other label on provided on form elements, WebKit should fall back to using @title
​https://bugs.webkit.org/show_bug.cgi?id=112842

Patch by Samuel White <Samuel White> on 2013-09-04
Reviewed by Chris Fleizach.

Source/WebCore:

Don't let input elements include empty labels in their accessibility title.

Test: platform/mac/accessibility/input-title.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):

LayoutTests:

Added test to ensure that input elements are computing their
accessibility title as expected.

• platform/mac/accessibility/input-title-expected.txt: Added.
• platform/mac/accessibility/input-title.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/accessibility/input-title-expected.txt (added)
• LayoutTests/platform/mac/accessibility/input-title.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-04  Samuel White  <samuel_white@apple.com>
+
+        AX: when no other label on provided on form elements, WebKit should fall back to using @title
+        https://bugs.webkit.org/show_bug.cgi?id=112842
+
+        Reviewed by Chris Fleizach.
+
+        Added test to ensure that input elements are computing their
+        accessibility title as expected.
+
+        * platform/mac/accessibility/input-title-expected.txt: Added.
+        * platform/mac/accessibility/input-title.html: Added.
+
 2013-09-04  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-04  Samuel White  <samuel_white@apple.com>
+
+        AX: when no other label on provided on form elements, WebKit should fall back to using @title
+        https://bugs.webkit.org/show_bug.cgi?id=112842
+
+        Reviewed by Chris Fleizach.
+
+        Don't let input elements include empty labels in their accessibility title.
+
+        Test: platform/mac/accessibility/input-title.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::titleElementText):
+
 2013-09-04  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -1172 +1172 @@
         if (label) {
             AccessibilityObject* labelObject = axObjectCache()->getOrCreate(label);
-            textOrder.append(AccessibilityText(label->innerText(), LabelByElementText, labelObject));
+            String innerText = label->innerText();
+            if (!innerText.isEmpty())
+                textOrder.append(AccessibilityText(innerText, LabelByElementText, labelObject));
             return;
         }