Changeset 155118 in webkit


Ignore:
Timestamp:
Sep 5, 2013 8:11:58 AM (11 years ago)
Author:
Csaba Osztrogonác
Message:

Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
​https://bugs.webkit.org/show_bug.cgi?id=120759

Reviewed by Filip Pizlo.

  • Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
  • Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r155117 r155118  
     12013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
     4        https://bugs.webkit.org/show_bug.cgi?id=120759
     5
     6        Reviewed by Filip Pizlo.
     7
     8        * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
     9        * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
     10
    1112013-09-05  Filip Pizlo  <fpizlo@apple.com>
    212

  • trunk/Tools/Scripts/run-fast-jsc

    r114587 r155118  
    3333cmdName=`basename $0`
    3434
    35 function usage()
     35usage()
    3636{
    3737    echo "usage: $cmdName [[--jsc | -j] <path-to-jsc>] [[--results-dir | -r] <results-path>]"
    … …  
    109109    if [ -f $expectedOut -a -f $jsTest ]
    110110    then
    111         echo "Testing $test ... \c"
    112         let numTestsRun=$numTestsRun+1
     111        if [ `uname` = 'Darwin' ]; then
     112            echo "Testing $test ... \c"
     113        else
     114            echo -n "Testing $test ..."
     115        fi
     116        numTestsRun=$(($numTestsRun+1))
    113117        $jscCmd $preScript $jsTest $postScript 2>$actualErr > $actualOut
    114118        JSC_RES=$?
    … …  
    139143        then
    140144            echo "$test" >> $passList
    141             let numPassed=$numPassed+1
     145            numPassed=$(($numPassed+1))
    142146        else
    143147            echo "$test" >> $failList
    144             let numFailed=$numFailed+1
     148            numFailed=$(($numFailed+1))
    145149            if [ $testCrashed -eq 1 ]
    146150            then
    147151                echo "$test" >> $crashList
    148                 let numCrashed=$numCrashed+1
     152                numCrashed=$(($numCrashed+1))
    149153            fi
    150154        fi

  • trunk/Tools/Scripts/run-javascriptcore-tests

    r155117 r155118  
    192192chdirWebKit();
    193193my $fastJSResultsDir = $productDir . "/fast-jsc-results";
    194 my $runFastJS = isAppleMacWebKit();
     194
     195# FIXME: run-fast-jsc tests doesn't work properly on Windows
     196# https://bugs.webkit.org/show_bug.cgi?id=120765
     197my $runFastJS = !isAppleWinWebKit();
     198
    195199if ($runFastJS) {
    196200    # Run the fast/js tests.
Note: See TracChangeset for help on using the changeset viewer.