Changeset 155141 in webkit
- Timestamp:
- Sep 5, 2013, 12:47:40 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r155139 r155141 1 2013-09-05 David Hyatt <hyatt@apple.com> 2 3 Make RenderBlock have a protected constructor.. 4 https://bugs.webkit.org/show_bug.cgi?id=120787 5 6 Reviewed by Beth Dakin. 7 8 Make sure nobody can create a RenderBlock directly. Make sure RenderBlockFlows 9 get made when a display:block/inline-block/compact/run-in is seen. 10 11 * html/HTMLDetailsElement.cpp: 12 (WebCore::HTMLDetailsElement::createRenderer): 13 * html/HTMLSummaryElement.cpp: 14 (WebCore::HTMLSummaryElement::createRenderer): 15 * rendering/RenderBlock.cpp: 16 (WebCore::RenderBlock::createAnonymous): 17 * rendering/RenderBlock.h: 18 * rendering/RenderObject.cpp: 19 (WebCore::RenderObject::createObject): 20 1 21 2013-09-05 David Hyatt <hyatt@apple.com> 2 22 -
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
r154903 r155141 28 28 #include "LocalizedStrings.h" 29 29 #include "MouseEvent.h" 30 #include "RenderBlock .h"30 #include "RenderBlockFlow.h" 31 31 #include "ShadowRoot.h" 32 32 #include "Text.h" … … 114 114 RenderObject* HTMLDetailsElement::createRenderer(RenderArena* arena, RenderStyle*) 115 115 { 116 return new (arena) RenderBlock (this);116 return new (arena) RenderBlockFlow(this); 117 117 } 118 118 -
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
r154877 r155141 31 31 #include "NodeRenderingTraversal.h" 32 32 #include "PlatformMouseEvent.h" 33 #include "RenderBlock .h"33 #include "RenderBlockFlow.h" 34 34 #include "ShadowRoot.h" 35 35 … … 69 69 RenderObject* HTMLSummaryElement::createRenderer(RenderArena* arena, RenderStyle*) 70 70 { 71 return new (arena) RenderBlock (this);71 return new (arena) RenderBlockFlow(this); 72 72 } 73 73 -
trunk/Source/WebCore/rendering/RenderBlock.cpp
r155139 r155141 238 238 RenderBlock* RenderBlock::createAnonymous(Document* document) 239 239 { 240 RenderBlock* renderer = new (document->renderArena()) RenderBlock (0);240 RenderBlock* renderer = new (document->renderArena()) RenderBlockFlow(0); 241 241 renderer->setDocumentForAnonymous(document); 242 242 return renderer; -
trunk/Source/WebCore/rendering/RenderBlock.h
r155139 r155141 90 90 #endif 91 91 92 protected: 92 93 explicit RenderBlock(ContainerNode*); 93 94 virtual ~RenderBlock(); 94 95 96 public: 95 97 static RenderBlock* createAnonymous(Document*); 96 98 -
trunk/Source/WebCore/rendering/RenderObject.cpp
r155139 r155141 208 208 if ((!style->hasAutoColumnCount() || !style->hasAutoColumnWidth()) && document.regionBasedColumnsEnabled()) 209 209 return new (arena) RenderMultiColumnBlock(element); 210 return new (arena) RenderBlock (element);210 return new (arena) RenderBlockFlow(element); 211 211 case LIST_ITEM: 212 212 return new (arena) RenderListItem(element);
Note:
See TracChangeset
for help on using the changeset viewer.