Changeset 155546 in webkit

Timestamp:

Sep 11, 2013 11:33:05 AM (11 years ago)

Author:

Simon Fraser

Message:

REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px
​https://bugs.webkit.org/show_bug.cgi?id=121137

Source/WebCore:

Reviewed by Ryosuke Niwa.

The change in r143483 made it so that negative text-indent gets added
to visual oveflow even when we have overflow:hidden, which is really bad
because it causes large repaints (and large layers) for a common-on-the-web
pattern.

Revert the change, and add a new test to make sure it doesn't regress.

I can't reproduce the bug it was trying to fix with the change reverted.

Tests: compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html

fast/repaint/negative-text-indent-with-overflow-hidden.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

LayoutTests:

Reviewed by Ryosuke Niwa.

Text-based repaint test, and test for compositing layer geometry.

• compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
• compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html: Added.
• fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added.
• fast/repaint/negative-text-indent-with-overflow-hidden.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt (added)
• LayoutTests/compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html (added)
• LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt (added)
• LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-10  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px
+        https://bugs.webkit.org/show_bug.cgi?id=121137
+
+        Reviewed by Ryosuke Niwa.
+        
+        Text-based repaint test, and test for compositing layer geometry.
+
+        * compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
+        * compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html: Added.
+        * fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added.
+        * fast/repaint/negative-text-indent-with-overflow-hidden.html: Added.
+
 2013-09-11  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-10  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px
+        https://bugs.webkit.org/show_bug.cgi?id=121137
+
+        Reviewed by Ryosuke Niwa.
+        
+        The change in r143483 made it so that negative text-indent gets added
+        to visual oveflow even when we have overflow:hidden, which is really bad
+        because it causes large repaints (and large layers) for a common-on-the-web
+        pattern.
+        
+        Revert the change, and add a new test to make sure it doesn't regress.
+        
+        I can't reproduce the bug it was trying to fix with the change reverted.
+
+        Tests: compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html
+               fast/repaint/negative-text-indent-with-overflow-hidden.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::computeOverflow):
+
 2013-09-10  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -1683 +1683 @@
     }
         
-    // Allow our overflow to catch cases where the caret in an empty editable element with negative text indent needs to get painted.
-    LayoutUnit textIndent = textIndentOffset();
-    if (textIndent < 0) {
-        LayoutRect clientRect(clientBoxRect());
-        LayoutRect rectToApply = LayoutRect(clientRect.x() + textIndent, clientRect.y(), clientRect.width() - min<LayoutUnit>(0, textIndent), clientRect.height());
-        addVisualOverflow(rectToApply);
-    }
-
     // Add visual overflow from box-shadow and border-image-outset.
     addVisualEffectOverflow();