Changeset 155582 in webkit

Timestamp:

Sep 11, 2013, 5:51:38 PM (12 years ago)

Author:

Simon Fraser

Message:

Make sure that layout is up-to-date when moving a WKView into a window, to avoid !needsLayout() assertions in RenderView::paint()
​https://bugs.webkit.org/show_bug.cgi?id=121196

Reviewed by Tim Horton.

When a WKView was moved into a window, it was possible for us to paint
without ensuring that layout is up-to-date. Fix this by having
WebPage::setIsInWindow() update layout if we are moving to a window.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-09-11  Simon Fraser  <simon.fraser@apple.com>
+
+        Make sure that layout is up-to-date when moving a WKView into a window, to avoid !needsLayout() assertions in RenderView::paint()
+        https://bugs.webkit.org/show_bug.cgi?id=121196
+
+        Reviewed by Tim Horton.
+        
+        When a WKView was moved into a window, it was possible for us to paint
+        without ensuring that layout is up-to-date. Fix this by having
+        WebPage::setIsInWindow() update layout if we are moving to a window.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setIsInWindow):
+
 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -2139 +2139 @@
     m_page->setIsInWindow(isInWindow);
 
+    if (isInWindow)
+        layoutIfNeeded();
+
     if (wantsDidUpdateViewInWindowState)
         m_sendDidUpdateInWindowStateTimer.startOneShot(0);