Changeset 156111 in webkit

Timestamp:

Sep 19, 2013, 1:07:25 PM (12 years ago)

Author:

msaboff@apple.com

Message:

JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
​https://bugs.webkit.org/show_bug.cgi?id=121625

Rubber-stamped by Filip Pizlo.

Chenged 16, 32 and 64 bit offsets to be signed. Kept the original tab indented
spacing to match the rest of the file.

• disassembler/udis86/udis86_syn-att.c:

(gen_operand):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• disassembler/udis86/udis86_syn-att.c (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-09-19  Michael Saboff  <msaboff@apple.com>
+
+        JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
+        https://bugs.webkit.org/show_bug.cgi?id=121625
+
+        Rubber-stamped by Filip Pizlo.
+
+        Chenged 16, 32 and 64 bit offsets to be signed.  Kept the original tab indented
+        spacing to match the rest of the file.
+
+        * disassembler/udis86/udis86_syn-att.c:
+        (gen_operand):
+
 2013-09-19  Daniel Bates  <dabates@apple.com>
 

trunk/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c

@@ -67 +67 @@
                         if (op->lval.sbyte < 0)
                                 mkasm(u, "-0x%x", (-op->lval.sbyte) & 0xff);
-                        else    mkasm(u, "0x%x", op->lval.sbyte);
+                        else
+                                mkasm(u, "0x%x", op->lval.sbyte);
                 } 
-                else if (op->offset == 16) 
-                        mkasm(u, "0x%x", op->lval.uword);
-                else if (op->offset == 32) 
-                        mkasm(u, "0x%lx", (unsigned long)op->lval.udword);
-                else if (op->offset == 64) 
-                        mkasm(u, "0x" FMT64 "x", op->lval.uqword);
+                else if (op->offset == 16) {
+                        if (op->lval.sword < 0)
+                                mkasm(u, "-0x%x", (-op->lval.sword) & 0xffff);
+                        else
+                                mkasm(u, "0x%x", op->lval.sword);
+                } else if (op->offset == 32) {
+                        if (op->lval.sdword < 0)
+                                mkasm(u, "-0x%x", (-op->lval.sdword) & 0xffffffff);
+                        else
+                                mkasm(u, "0x%x", op->lval.sdword);
+                } else if (op->offset == 64) {
+                        if (op->lval.sdword < 0)
+                                mkasm(u, "-0x" FMT64 "x", -op->lval.sqword);
+                        else
+                                mkasm(u, "0x" FMT64 "x", op->lval.sqword);
+                }
 
                 if (op->base)