Changeset 156255 in webkit

Timestamp:

Sep 22, 2013, 7:59:16 PM (11 years ago)

Author:

Antti Koivisto

Message:

Fix functions calling to RenderObject superclass to call RenderElement instead
​https://bugs.webkit.org/show_bug.cgi?id=121773

Reviewed by Andreas Kling.

The class hierarchy has a new class. Superclass calls should be pointed there instead to
avoid future bugs.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::setSelectionState):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):

• rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::styleDidChange):

• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::styleWillChange):
(WebCore::RenderSVGModelObject::styleDidChange):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBoxModelObject.cpp (modified) (1 diff)
• rendering/RenderLayerModelObject.cpp (modified) (1 diff)
• rendering/svg/RenderSVGGradientStop.cpp (modified) (1 diff)
• rendering/svg/RenderSVGModelObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-22  Antti Koivisto  <antti@apple.com>
+
+        Fix functions calling to RenderObject superclass to call RenderElement instead
+        https://bugs.webkit.org/show_bug.cgi?id=121773
+
+        Reviewed by Andreas Kling.
+
+        The class hierarchy has a new class. Superclass calls should be pointed there instead to
+        avoid future bugs.
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::setSelectionState):
+        * rendering/RenderLayerModelObject.cpp:
+        (WebCore::RenderLayerModelObject::styleWillChange):
+        (WebCore::RenderLayerModelObject::styleDidChange):
+        * rendering/svg/RenderSVGGradientStop.cpp:
+        (WebCore::RenderSVGGradientStop::styleDidChange):
+        * rendering/svg/RenderSVGModelObject.cpp:
+        (WebCore::RenderSVGModelObject::styleWillChange):
+        (WebCore::RenderSVGModelObject::styleDidChange):
+
 2013-09-22  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -79 +79 @@
     if ((state == SelectionStart && selectionState() == SelectionEnd)
         || (state == SelectionEnd && selectionState() == SelectionStart))
-        RenderObject::setSelectionState(SelectionBoth);
+        RenderLayerModelObject::setSelectionState(SelectionBoth);
     else
-        RenderObject::setSelectionState(state);
+        RenderLayerModelObject::setSelectionState(state);
 
     // FIXME: We should consider whether it is OK propagating to ancestor RenderInlines.

trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp

@@ -132 +132 @@
     }
 
-    RenderObject::styleWillChange(diff, newStyle);
+    RenderElement::styleWillChange(diff, newStyle);
 }
 
 void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
-    RenderObject::styleDidChange(diff, oldStyle);
+    RenderElement::styleDidChange(diff, oldStyle);
     updateFromStyle();
 

trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp

@@ -45 +45 @@
 void RenderSVGGradientStop::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
-    RenderObject::styleDidChange(diff, oldStyle);
+    RenderElement::styleDidChange(diff, oldStyle);
     if (diff == StyleDifferenceEqual)
         return;

trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp

@@ -106 +106 @@
             setNeedsTransformUpdate();
     }
-    RenderObject::styleWillChange(diff, newStyle);
+    RenderElement::styleWillChange(diff, newStyle);
 }
 
 void RenderSVGModelObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
-    RenderObject::styleDidChange(diff, oldStyle);
+    RenderElement::styleDidChange(diff, oldStyle);
     SVGResourcesCache::clientStyleChanged(this, diff, style());
 }