Changeset 156404 in webkit

Timestamp:

Sep 25, 2013, 10:45:59 AM (11 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
​https://bugs.webkit.org/show_bug.cgi?id=121904

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/table/hittest-self-painting.html

Original reduction by Philippe Wittenbergh.

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

Tighten a bit.

(WebCore::RenderTableRow::nodeAtPoint):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

These flipped accidentally in r156355.

LayoutTests:

• fast/table/hittest-self-painting-expected.txt: Added.
• fast/table/hittest-self-painting.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/table/hittest-self-painting-expected.txt (added)
• LayoutTests/fast/table/hittest-self-painting.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTableRow.cpp (modified) (2 diffs)
• Source/WebCore/rendering/RenderTableSection.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-25  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
+        https://bugs.webkit.org/show_bug.cgi?id=121904
+
+        Reviewed by Andreas Kling.
+
+        * fast/table/hittest-self-painting-expected.txt: Added.
+        * fast/table/hittest-self-painting.html: Added.
+
 2013-09-25  Sanghyup Lee  <sh53.lee@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-25  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
+        https://bugs.webkit.org/show_bug.cgi?id=121904
+
+        Reviewed by Andreas Kling.
+
+        Test: fast/table/hittest-self-painting.html
+        
+        Original reduction by Philippe Wittenbergh.
+
+        * rendering/RenderTableRow.cpp:
+        (WebCore::RenderTableRow::styleDidChange):
+        
+            Tighten a bit.
+
+        (WebCore::RenderTableRow::nodeAtPoint):
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::nodeAtPoint):
+        
+            These flipped accidentally in r156355.
+
 2013-09-25  Alberto Garcia  <berto@igalia.com>
 

trunk/Source/WebCore/rendering/RenderTableRow.cpp

@@ -82 +82 @@
             // This only happens when borders are collapsed, since they end up affecting the border sides of the cell
             // itself.
-            for (RenderBox* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
-                if (!childBox->isTableCell())
-                    continue;
-                childBox->setChildNeedsLayout(true, MarkOnlyThis);
-            }
+            for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell())
+                cell->setChildNeedsLayout(true, MarkOnlyThis);
         }
     }
@@ -217 +214 @@
         // table-specific hit-test method (which we should do for performance reasons anyway),
         // then we can remove this check.
-        if (cell->hasSelfPaintingLayer()) {
+        if (!cell->hasSelfPaintingLayer()) {
             LayoutPoint cellPoint = flipForWritingModeForChild(cell, accumulatedOffset);
             if (cell->nodeAtPoint(request, result, locationInContainer, cellPoint, action)) {

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -1353 +1353 @@
             // table-specific hit-test method (which we should do for performance reasons anyway),
             // then we can remove this check.
-            if (row->hasSelfPaintingLayer()) {
+            if (!row->hasSelfPaintingLayer()) {
                 LayoutPoint childPoint = flipForWritingModeForChild(row, adjustedLocation);
                 if (row->nodeAtPoint(request, result, locationInContainer, childPoint, action)) {