Changeset 157093 in webkit


Ignore:
Timestamp:
Oct 8, 2013 2:41:34 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-08
Reviewed by Darin Adler.

Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
always true'.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r157082 r157093  
     12013-10-08  Robert Plociennik  <r.plociennik@samsung.com>
     2
     3        JavaScriptCore fails to build
     4        https://bugs.webkit.org/show_bug.cgi?id=122440
     5
     6        Reviewed by Darin Adler.
     7
     8        Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
     9        always true'.
     10
     11        * debugger/DebuggerCallFrame.cpp:
     12        (JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.
     13
    1142013-10-07  Andreas Kling  <akling@apple.com>
    215
  • trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp

    r156936 r157093  
    183183    LineAndColumnFunctor functor;
    184184    callFrame->iterate(functor);
    185     ASSERT(!callFrame->codeBlock() || functor.line() >= 0);
    186     ASSERT(!callFrame->codeBlock() || functor.column() >= 0);
    187185    return TextPosition(OrdinalNumber::fromOneBasedInt(functor.line()), OrdinalNumber::fromOneBasedInt(functor.column()));
    188186}
Note: See TracChangeset for help on using the changeset viewer.