Changeset 157124 in webkit

Timestamp:

Oct 8, 2013 11:25:16 AM (11 years ago)

Author:

ChangSeok Oh

Message:

[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
​https://bugs.webkit.org/show_bug.cgi?id=122506

Reviewed by Gustavo Noronha Silva.

Gdk event returned by gtk_get_current_event should be freed after using it.

No functionality changed.

• platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::show):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/PopupMenuGtk.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-08  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
+        https://bugs.webkit.org/show_bug.cgi?id=122506
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Gdk event returned by gtk_get_current_event should be freed after using it.
+
+        No functionality changed.
+
+        * platform/gtk/PopupMenuGtk.cpp:
+        (WebCore::PopupMenuGtk::show):
+
 2013-10-08  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp

@@ -29 +29 @@
 
 #include "FrameView.h"
-#include <wtf/gobject/GOwnPtr.h>
+#include "GOwnPtrGtk.h"
 #include "GtkUtilities.h"
 #include "HostWindow.h"
 #include <gtk/gtk.h>
+#include <wtf/gobject/GOwnPtr.h>
 #include <wtf/text/CString.h>
 
@@ -88 +89 @@
     menuPosition.move(0, rect.height());
 
-    m_popup->popUp(rect.size(), menuPosition, size, index, gtk_get_current_event());
+    GOwnPtr<GdkEvent> currentEvent(gtk_get_current_event());
+    m_popup->popUp(rect.size(), menuPosition, size, index, currentEvent.get());
 
     // GTK can refuse to actually open the menu when mouse grabs fails.