Changeset 157188 in webkit


Ignore:
Timestamp:
Oct 9, 2013 2:58:28 PM (11 years ago)
Author:
ap@apple.com
Message:

Add API tests to the Dashbord page.

​https://bugs.webkit.org/show_bug.cgi?id=122283

Patch by Timothy Hatcher <​timothy@apple.com> on 2013-10-09
Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.apiTestResultsURLForIteration):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js

    r156685 r157188  
    6969    constructor: Buildbot,
    7070    __proto__: BaseObject.prototype,
     71
     72    buildPageURLForIteration: function(iteration)
     73    {
     74        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id;
     75    }
    7176};

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js

    r157187 r157188  
    9090                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "binding tests failed");
    9191                } else {
     92                    var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
    9293                    var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
    93                     var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures);
     94                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
    9495                }
    9596

  • trunk/Tools/ChangeLog

    r157187 r157188  
    2222        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
    2323        (BuildbotIteration.prototype.update):
     24
     252013-10-09  Alexey Proskuryakov  <ap@apple.com>
     26
     27        build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
     28        https://bugs.webkit.org/show_bug.cgi?id=122573
     29
     30        Reviewed by Tim Hatcher.
     31
     32        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
     33        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
     34
     35        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
     36        (Buildbot.prototype.buildPageURLForIteration): Added.
    2437
    25382013-10-09  Alexey Proskuryakov  <ap@apple.com>
Note: See TracChangeset for help on using the changeset viewer.