Changeset 157346 in webkit

Timestamp:

Oct 12, 2013 1:33:29 PM (11 years ago)

Author:

Antti Koivisto

Message:

Move line dirtying code to RenderTextLineBoxes
​https://bugs.webkit.org/show_bug.cgi?id=122699

Reviewed by Andreas Kling.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::removeAllFromParent):

Also moved the removal loop.

(WebCore::RenderTextLineBoxes::dirtyAll):
(WebCore::RenderTextLineBoxes::dirtyRange):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderText.cpp (modified) (3 diffs)
• rendering/RenderTextLineBoxes.cpp (modified) (3 diffs)
• rendering/RenderTextLineBoxes.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-12  Antti Koivisto  <antti@apple.com>
+
+        Move line dirtying code to RenderTextLineBoxes
+        https://bugs.webkit.org/show_bug.cgi?id=122699
+
+        Reviewed by Andreas Kling.
+
+        * rendering/RenderTextLineBoxes.cpp:
+        (WebCore::RenderTextLineBoxes::removeAllFromParent):
+        
+            Also moved the removal loop.
+
+        (WebCore::RenderTextLineBoxes::dirtyAll):
+        (WebCore::RenderTextLineBoxes::dirtyRange):
+
 2013-10-12  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderText.cpp

@@ -240 +240 @@
 void RenderText::removeAndDestroyTextBoxes()
 {
-    if (!documentBeingDestroyed()) {
-        if (firstTextBox()) {
-            for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox())
-                box->remove();
-        } else if (parent())
-            parent()->dirtyLinesFromChangedChild(this);
-    }
+    if (!documentBeingDestroyed())
+        m_lineBoxes.removeAllFromParent(*this);
     m_lineBoxes.deleteAll(*this);
 }
@@ -1125 +1120 @@
         return;
 
-    unsigned oldLen = textLength();
-    unsigned newLen = text.length();
-    int delta = newLen - oldLen;
+    int delta = text.length() - textLength();
     unsigned end = len ? offset + len - 1 : offset;
 
-    RootInlineBox* firstRootBox = 0;
-    RootInlineBox* lastRootBox = 0;
-
-    bool dirtiedLines = false;
-
-    // Dirty all text boxes that include characters in between offset and offset+len.
-    for (InlineTextBox* curr = firstTextBox(); curr; curr = curr->nextTextBox()) {
-        // FIXME: This shouldn't rely on the end of a dirty line box. See https://bugs.webkit.org/show_bug.cgi?id=97264
-        // Text run is entirely before the affected range.
-        if (curr->end() < offset)
-            continue;
-
-        // Text run is entirely after the affected range.
-        if (curr->start() > end) {
-            curr->offsetRun(delta);
-            RootInlineBox& rootBox = curr->root();
-            if (!firstRootBox) {
-                firstRootBox = &rootBox;
-                if (!dirtiedLines) {
-                    // The affected area was in between two runs. Go ahead and mark the root box of
-                    // the run after the affected area as dirty.
-                    firstRootBox->markDirty();
-                    dirtiedLines = true;
-                }
-            }
-            lastRootBox = &rootBox;
-        } else if (curr->end() >= offset && curr->end() <= end) {
-            // Text run overlaps with the left end of the affected range.
-            curr->dirtyLineBoxes();
-            dirtiedLines = true;
-        } else if (curr->start() <= offset && curr->end() >= end) {
-            // Text run subsumes the affected range.
-            curr->dirtyLineBoxes();
-            dirtiedLines = true;
-        } else if (curr->start() <= end && curr->end() >= end) {
-            // Text run overlaps with right end of the affected range.
-            curr->dirtyLineBoxes();
-            dirtiedLines = true;
-        }
-    }
-
-    // Now we have to walk all of the clean lines and adjust their cached line break information
-    // to reflect our updated offsets.
-    if (lastRootBox)
-        lastRootBox = lastRootBox->nextRootBox();
-    if (firstRootBox) {
-        RootInlineBox* prev = firstRootBox->prevRootBox();
-        if (prev)
-            firstRootBox = prev;
-    } else if (lastTextBox()) {
-        ASSERT(!lastRootBox);
-        firstRootBox = &lastTextBox()->root();
-        firstRootBox->markDirty();
-        dirtiedLines = true;
-    }
-    for (RootInlineBox* curr = firstRootBox; curr && curr != lastRootBox; curr = curr->nextRootBox()) {
-        if (curr->lineBreakObj() == this && curr->lineBreakPos() > end)
-            curr->setLineBreakPos(curr->lineBreakPos() + delta);
-    }
-
-    // If the text node is empty, dirty the line where new text will be inserted.
-    if (!firstTextBox() && parent()) {
-        parent()->dirtyLinesFromChangedChild(this);
-        dirtiedLines = true;
-    }
-
-    m_linesDirty = dirtiedLines;
-    setText(text, force || dirtiedLines);
+    m_linesDirty = m_lineBoxes.dirtyRange(*this, offset, end, delta);
+
+    setText(text, force || m_linesDirty);
 }
 
@@ -1339 +1267 @@
     if (fullLayout)
         m_lineBoxes.deleteAll(*this);
-    else if (!m_linesDirty) {
-        for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox())
-            box->dirtyLineBoxes();
-    }
+    else if (!m_linesDirty)
+        m_lineBoxes.dirtyAll();
     m_linesDirty = false;
 }

trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp

@@ -29 +29 @@
 #include "InlineTextBox.h"
 #include "RenderStyle.h"
+#include "RootInlineBox.h"
 
 namespace WebCore {
@@ -104 +105 @@
 }
 
+void RenderTextLineBoxes::removeAllFromParent(RenderText& renderer)
+{
+    if (!m_first) {
+        if (renderer.parent())
+            renderer.parent()->dirtyLinesFromChangedChild(&renderer);
+        return;
+    }
+    for (auto box = m_first; box; box = box->nextTextBox())
+        box->remove();
+}
+
 void RenderTextLineBoxes::deleteAll(RenderText& renderer)
 {
@@ -213 +225 @@
 }
 
+void RenderTextLineBoxes::dirtyAll()
+{
+    for (auto box = m_first; box; box = box->nextTextBox())
+        box->dirtyLineBoxes();
+}
+
+bool RenderTextLineBoxes::dirtyRange(RenderText& renderer, unsigned start, unsigned end, int lengthDelta)
+{
+    RootInlineBox* firstRootBox = nullptr;
+    RootInlineBox* lastRootBox = nullptr;
+
+    // Dirty all text boxes that include characters in between offset and offset+len.
+    bool dirtiedLines = false;
+    for (auto current = m_first; current; current = current->nextTextBox()) {
+        // FIXME: This shouldn't rely on the end of a dirty line box. See https://bugs.webkit.org/show_bug.cgi?id=97264
+        // Text run is entirely before the affected range.
+        if (current->end() < start)
+            continue;
+        // Text run is entirely after the affected range.
+        if (current->start() > end) {
+            current->offsetRun(lengthDelta);
+            auto& rootBox = current->root();
+            if (!firstRootBox) {
+                firstRootBox = &rootBox;
+                if (!dirtiedLines) {
+                    // The affected area was in between two runs. Go ahead and mark the root box of
+                    // the run after the affected area as dirty.
+                    firstRootBox->markDirty();
+                    dirtiedLines = true;
+                }
+            }
+            lastRootBox = &rootBox;
+            continue;
+        }
+        if (current->end() >= start && current->end() <= end) {
+            // Text run overlaps with the left end of the affected range.
+            current->dirtyLineBoxes();
+            dirtiedLines = true;
+            continue;
+        }
+        if (current->start() <= start && current->end() >= end) {
+            // Text run subsumes the affected range.
+            current->dirtyLineBoxes();
+            dirtiedLines = true;
+            continue;
+        }
+        if (current->start() <= end && current->end() >= end) {
+            // Text run overlaps with right end of the affected range.
+            current->dirtyLineBoxes();
+            dirtiedLines = true;
+            continue;
+        }
+    }
+
+    // Now we have to walk all of the clean lines and adjust their cached line break information
+    // to reflect our updated offsets.
+    if (lastRootBox)
+        lastRootBox = lastRootBox->nextRootBox();
+    if (firstRootBox) {
+        auto previousRootBox = firstRootBox->prevRootBox();
+        if (previousRootBox)
+            firstRootBox = previousRootBox;
+    } else if (m_last) {
+        ASSERT(!lastRootBox);
+        firstRootBox = &m_last->root();
+        firstRootBox->markDirty();
+        dirtiedLines = true;
+    }
+    for (auto current = firstRootBox; current && current != lastRootBox; current = current->nextRootBox()) {
+        if (current->lineBreakObj() == &renderer && current->lineBreakPos() > end)
+            current->setLineBreakPos(current->lineBreakPos() + lengthDelta);
+    }
+    
+    // If the text node is empty, dirty the line where new text will be inserted.
+    if (!m_first && renderer.parent()) {
+        renderer.parent()->dirtyLinesFromChangedChild(&renderer);
+        dirtiedLines = true;
+    }
+    return dirtiedLines;
+}
+
 #if !ASSERT_DISABLED
 RenderTextLineBoxes::~RenderTextLineBoxes()

trunk/Source/WebCore/rendering/RenderTextLineBoxes.h

@@ -48 +48 @@
     void remove(InlineTextBox&);
 
+    void removeAllFromParent(RenderText&);
     void deleteAll(RenderText&);
 
@@ -58 +59 @@
     IntRect boundingBox(const RenderText&) const;
     LayoutRect visualOverflowBoundingBox(const RenderText&) const;
+
+    void dirtyAll();
+    bool dirtyRange(RenderText&, unsigned start, unsigned end, int lengthDelta);
 
 #if !ASSERT_DISABLED