Changeset 157736 in webkit

Timestamp:

Oct 21, 2013, 2:22:26 PM (12 years ago)

Author:

Simon Fraser

Message:

Use pink layer borders for compositing layers with a contents layer
​https://bugs.webkit.org/show_bug.cgi?id=123118

Reviewed by Dean Jackson.

With the existing layer border colors, it's not possible to distinguish an empty
layer from one with solid color, image or video contents. So use a pink color
for those. This makes it easier to diagnose bugs like 122784.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getDebugBorderInfo):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GraphicsLayer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-21  Simon Fraser  <simon.fraser@apple.com>
+
+        Use pink layer borders for compositing layers with a contents layer
+        https://bugs.webkit.org/show_bug.cgi?id=123118
+
+        Reviewed by Dean Jackson.
+
+        With the existing layer border colors, it's not possible to distinguish an empty
+        layer from one with solid color, image or video contents. So use a pink color
+        for those. This makes it easier to diagnose bugs like 122784.
+
+        * platform/graphics/GraphicsLayer.cpp:
+        (WebCore::GraphicsLayer::getDebugBorderInfo):
+
 2013-10-21  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp

@@ -368 +368 @@
         return;
     }
+
+    if (hasContentsLayer()) {
+        color = Color(255, 150, 255, 200); // non-painting layer with contents: pink
+        width = 2;
+        return;
+    }
     
     if (masksToBounds()) {
@@ -374 +380 @@
         return;
     }
-        
+
     color = Color(255, 255, 0, 192); // container: yellow
     width = 2;