Changeset 158104 in webkit


Ignore:
Timestamp:
Oct 28, 2013 2:57:48 AM (10 years ago)
Author:
mario@webkit.org
Message:

[GTK] Expose title and alternative text for links in image maps
​https://bugs.webkit.org/show_bug.cgi?id=84045

Reviewed by Chris Fleizach.

Source/WebCore:

Change the way we decide when the title attribute should be
used for the accessible description, by not relying in the
titleTagShouldBeUsedInDescriptionField() helper function but
in whether we have found a visible text for it or not.

This actually mimics what the Mac port does and so makes possible
to share both the layout test and its expected results.

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(accessibilityDescription): Update the method to determine
whether the title attribute should be used for the description.

LayoutTests:

Share test expectations among Mac, GTK and EFL ports and
remove expected failures for GTK and EFL.

  • accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
  • platform/gtk/accessibility/image-map1-expected.txt: Removed.
  • platform/efl/TestExpectations: Removed failure expectations.
  • platform/gtk/TestExpectations: Ditto.
Location:
trunk
Files:
1 deleted
5 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r158092 r158104  
     12013-10-28  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [GTK] Expose title and alternative text for links in image maps
     4        https://bugs.webkit.org/show_bug.cgi?id=84045
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Share test expectations among Mac, GTK and EFL ports and
     9        remove expected failures for GTK and EFL.
     10
     11        * accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
     12        * platform/gtk/accessibility/image-map1-expected.txt: Removed.
     13        * platform/efl/TestExpectations: Removed failure expectations.
     14        * platform/gtk/TestExpectations: Ditto.
     15
    1162013-10-26  Simon Fraser  <simon.fraser@apple.com>
    217

  • trunk/LayoutTests/platform/efl/TestExpectations

    r157910 r158104  
    14141414
    14151415webkit.org/b/121684 accessibility/aria-describedby-on-input.html [ Failure ]
    1416 webkit.org/b/84045 accessibility/image-map1.html [ Failure ]
    14171416webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ]
    14181417

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r157921 r158104  
    14041404webkit.org/b/120596 css3/masking/mask-repeat-space-padding.html [ ImageOnlyFailure ]
    14051405
    1406 webkit.org/b/84045 accessibility/image-map1.html [ Failure ]
    1407 
    14081406webkit.org/b/120836 fast/regions/text-region-split-vertical-rl.html [ Failure ]
    14091407

  • trunk/Source/WebCore/ChangeLog

    r158103 r158104  
     12013-10-28  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [GTK] Expose title and alternative text for links in image maps
     4        https://bugs.webkit.org/show_bug.cgi?id=84045
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Change the way we decide when the title attribute should be
     9        used for the accessible description, by not relying in the
     10        titleTagShouldBeUsedInDescriptionField() helper function but
     11        in whether we have found a visible text for it or not.
     12
     13        This actually mimics what the Mac port does and so makes possible
     14        to share both the layout test and its expected results.
     15
     16        * accessibility/atk/WebKitAccessibleUtil.cpp:
     17        (accessibilityDescription): Update the method to determine
     18        whether the title attribute should be used for the description.
     19
    1202013-10-28  Bastien Nocera <hadess@hadess.net>
    221

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp

    r144636 r158104  
    126126
    127127    unsigned length = textOrder.size();
     128    bool visibleTextAvailable = false;
    128129    for (unsigned k = 0; k < length; k++) {
    129130        const AccessibilityText& text = textOrder[k];
    … …  
    132133            return text.text;
    133134
    134         if (text.textSource == TitleTagText && titleTagShouldBeUsedInDescriptionField(coreObject))
     135        switch (text.textSource) {
     136        case VisibleText:
     137        case ChildrenText:
     138        case LabelByElementText:
     139            visibleTextAvailable = true;
     140        default:
     141            break;
     142        }
     143
     144        if (text.textSource == TitleTagText && !visibleTextAvailable)
    135145            return text.text;
    136146    }
Note: See TracChangeset for help on using the changeset viewer.