Changeset 158267 in webkit


Ignore:
Timestamp:
Oct 30, 2013 5:34:42 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] accessibility/svg-remote-element.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=101185

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-30
Reviewed by Chris Fleizach.

Tools:

Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.

LayoutTests:

Provided new test expectations since resulting discrepancies are believed to be
platform related.

  • platform/gtk-wk2/TestExpectations: The test is no longer failing.
  • platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
  • platform/gtk/TestExpectations: The test is no longer failing.
Location:
trunk
Files:
1 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r158264 r158267  
     12013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
     2
     3        [GTK] accessibility/svg-remote-element.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=101185
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Provided new test expectations since resulting discrepancies are believed to be
     9        platform related.
     10
     11        * platform/gtk-wk2/TestExpectations: The test is no longer failing.
     12        * platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
     13        * platform/gtk/TestExpectations: The test is no longer failing.
     14
    1152013-10-30  Krzysztof Czech  <k.czech@samsung.com>
    216

  • trunk/LayoutTests/platform/gtk-wk2/TestExpectations

    r157994 r158267  
    343343webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Failure ]
    344344webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ]
    345 webkit.org/b/106346 accessibility/svg-remote-element.html [ Failure ]
    346345
    347346# svg/ failures

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r158263 r158267  
    883883webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ]
    884884webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ]
    885 webkit.org/b/101185 accessibility/svg-remote-element.html [ Failure ]
    886885webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ]
    887886webkit.org/b/98378 accessibility/textarea-line-for-index.html [ Failure ]

  • trunk/Tools/ChangeLog

    r158266 r158267  
     12013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
     2
     3        [GTK] accessibility/svg-remote-element.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=101185
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Implemented missing methods by mimicing existing functionality in
     9        AccessibilityObject::clickPoint() using available ATK API.
     10
     11        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
     12        (AccessibilityUIElement::clickPointX): Implemented.
     13        (AccessibilityUIElement::clickPointY): Implemented.
     14        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     15        (WTR::AccessibilityUIElement::clickPointX): Implemented.
     16        (WTR::AccessibilityUIElement::clickPointY): Implemented.
     17
    1182013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
    219

  • trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp

    r157859 r158267  
    744744double AccessibilityUIElement::clickPointX()
    745745{
    746     // Note: This is not something we have in ATK.
    747     return 0;
     746    if (!ATK_IS_COMPONENT(m_element))
     747        return 0;
     748
     749    int x, y;
     750    atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
     751
     752    int width, height;
     753    atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
     754
     755    return x + width / 2.0;
    748756}
    749757
    750758double AccessibilityUIElement::clickPointY()
    751759{
    752     // Note: This is not something we have in ATK.
    753     return 0;
     760    if (!ATK_IS_COMPONENT(m_element))
     761        return 0;
     762
     763    int x, y;
     764    atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
     765
     766    int width, height;
     767    atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
     768
     769    return y + height / 2.0;
    754770}
    755771

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r157859 r158267  
    869869double AccessibilityUIElement::clickPointX()
    870870{
    871     // FIXME: implement
    872     return 0;
     871    if (!ATK_IS_COMPONENT(m_element.get()))
     872        return 0;
     873
     874    int x, y;
     875    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
     876
     877    int width, height;
     878    atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
     879
     880    return x + width / 2.0;
    873881}
    874882
    875883double AccessibilityUIElement::clickPointY()
    876884{
    877     // FIXME: implement
    878     return 0;
     885    if (!ATK_IS_COMPONENT(m_element.get()))
     886        return 0;
     887
     888    int x, y;
     889    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
     890
     891    int width, height;
     892    atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
     893
     894    return y + height / 2.0;
    879895}
    880896
Note: See TracChangeset for help on using the changeset viewer.