Changeset 158872 in webkit

Timestamp:

Nov 7, 2013 1:54:36 PM (10 years ago)

Author:

andersca@apple.com

Message:

Don't repaint the view when the web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=124013

Reviewed by Dan Bernstein.

It's up to each individual port to decide whether the view should be repainted when the web process crashes.

• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/PageClientImpl.mm (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-11-07  Anders Carlsson  <andersca@apple.com>
+
+        Don't repaint the view when the web process crashes
+        https://bugs.webkit.org/show_bug.cgi?id=124013
+
+        Reviewed by Dan Bernstein.
+
+        It's up to each individual port to decide whether the view should be repainted when the web process crashes.
+
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::setViewNeedsDisplay):
+        (WebKit::PageClientImpl::displayView):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::resetStateAfterProcessExited):
+
 2013-11-07  Tamas Gergely  <gertom@inf.u-szeged.hu>
 

trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm

@@ -141 +141 @@
 void PageClientImpl::setViewNeedsDisplay(const WebCore::IntRect& rect)
 {
-    [m_wkView setNeedsDisplayInRect:rect];
+    ASSERT_NOT_REACHED();
 }
 
 void PageClientImpl::displayView()
 {
-    [m_wkView displayIfNeeded];
+    ASSERT_NOT_REACHED();
 }
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -3797 +3797 @@
     m_pendingLearnOrIgnoreWordMessageCount = 0;
 
-    // If the call out to the loader client didn't cause the web process to be relaunched,
-    // we'll call setNeedsDisplay on the view so that we won't have the old contents showing.
-    // If the call did cause the web process to be relaunched, we'll keep the old page contents showing
-    // until the new web process has painted its contents.
-    setViewNeedsDisplay(IntRect(IntPoint(), viewSize()));
-
     // Can't expect DidReceiveEvent notifications from a crashed web process.
     m_keyEventQueue.clear();