Changeset 158979 in webkit

Timestamp:

Nov 8, 2013 5:13:29 PM (10 years ago)

Author:

eric.carlson@apple.com

Message:

getCueAsHTML() on an empty cue should return a document fragment
​https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the

passed an empty string.

LayoutTests:

• media/track/track-cue-empty-cue-text-expected.txt: Added.
• media/track/track-cue-empty-cue-text.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/track/track-cue-empty-cue-text-expected.txt (added)
• LayoutTests/media/track/track-cue-empty-cue-text.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/track/WebVTTParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-11-08  Eric Carlson  <eric.carlson@apple.com>
+
+        getCueAsHTML() on an empty cue should return a document fragment
+        https://bugs.webkit.org/show_bug.cgi?id=124084
+
+        Reviewed by Darin Adler.
+
+        * media/track/track-cue-empty-cue-text-expected.txt: Added.
+        * media/track/track-cue-empty-cue-text.html: Added.
+
 2013-11-08  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-11-08  Eric Carlson  <eric.carlson@apple.com>
+
+        getCueAsHTML() on an empty cue should return a document fragment
+        https://bugs.webkit.org/show_bug.cgi?id=124084
+
+        Reviewed by Darin Adler.
+
+        Test: media/track/track-cue-empty-cue-text.html
+
+        * html/track/WebVTTParser.cpp:
+        (WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the
+            passed an empty string.
+
 2013-11-08  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/track/WebVTTParser.cpp

@@ -349 +349 @@
     // 4.8.10.13.5 WebVTT cue text DOM construction rules.
 
-    if (!text.length())
-        return 0;
-
     ASSERT(m_scriptExecutionContext->isDocument());
     Document* document = toDocument(m_scriptExecutionContext);
     
     RefPtr<DocumentFragment> fragment = DocumentFragment::create(*document);
+
+    if (text.isEmpty()) {
+        fragment->parserAppendChild(Text::create(*document, emptyString()));
+        return fragment.release();
+    }
+
     m_currentNode = fragment;
     m_tokenizer->reset();