Changeset 159033 in webkit

Timestamp:

Nov 10, 2013 4:13:11 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Cleanup the EFL --minimal build from unused parameters
​https://bugs.webkit.org/show_bug.cgi?id=124048

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-11-10
Reviewed by Gyuyoung Kim.

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):

• ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set):

• ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientEfl.cpp (modified) (1 diff)
• ewk/ewk_settings.cpp (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (2 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2013-11-10  Tibor Meszaros  <mtibor@inf.u-szeged.hu>
+
+        Cleanup the EFL --minimal build from unused parameters
+        https://bugs.webkit.org/show_bug.cgi?id=124048
+
+        Reviewed by Gyuyoung Kim.
+
+        * WebCoreSupport/ChromeClientEfl.cpp:
+        (WebCore::ChromeClientEfl::createWindow):
+        * ewk/ewk_settings.cpp:
+        (ewk_settings_web_database_path_set):
+        * ewk/ewk_view.cpp:
+        (ewk_view_visibility_state_set):
+        (ewk_view_visibility_state_get):
+
 2013-11-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp

@@ -156 +156 @@
     if (frame->document() && frame->document()->webkitCurrentFullScreenElement())
         frame->document()->webkitCancelFullScreen();
+#else
+    UNUSED_PARAM(frame);
 #endif
 

trunk/Source/WebKit/efl/ewk/ewk_settings.cpp

@@ -144 +144 @@
     WebCore::DatabaseManager::manager().setDatabaseDirectoryPath(WTF::String::fromUTF8(path));
     eina_stringshare_replace(&s_webDatabasePath, path);
+#else
+    UNUSED_PARAM(path);
 #endif
 }

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -4256 +4256 @@
 #else
     DBG("PAGE_VISIBILITY_API is disabled.");
+    UNUSED_PARAM(ewkView);
+    UNUSED_PARAM(pageVisibilityState);
+    UNUSED_PARAM(initialState);
     return false;
 #endif
@@ -4269 +4272 @@
 #else
     DBG("PAGE_VISIBILITY_API is disabled.");
+    UNUSED_PARAM(ewkView);
     return EWK_PAGE_VISIBILITY_STATE_VISIBLE;
 #endif