Changeset 159092 in webkit


Ignore:
Timestamp:
Nov 11, 2013 8:39:34 PM (10 years ago)
Author:
gyuyoung.kim@samsung.com
Message:

Clean up static_cast<Element*> usage
https://bugs.webkit.org/show_bug.cgi?id=124133

Reviewed by Andreas Kling.

We need to use toFoo cast function instead of static_cast<>. Though there is toElement(),
static_cast<Element*> is still being used.

No new tests, no behavior changes.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • dom/ElementTraversal.h:

(WebCore::::lastWithinTemplate):
(WebCore::::nextTemplate):
(WebCore::::previousTemplate):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r159089 r159092  
     12013-11-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
     2
     3        Clean up static_cast<Element*> usage
     4        https://bugs.webkit.org/show_bug.cgi?id=124133
     5
     6        Reviewed by Andreas Kling.
     7
     8        We need to use toFoo cast function instead of static_cast<>. Though there is toElement(),
     9        static_cast<Element*> is still being used.
     10
     11        No new tests, no behavior changes.
     12
     13        * bindings/gobject/WebKitDOMPrivate.cpp:
     14        (WebKit::wrap):
     15        * dom/ElementTraversal.h:
     16        (WebCore::::lastWithinTemplate):
     17        (WebCore::::nextTemplate):
     18        (WebCore::::previousTemplate):
     19
    1202013-11-11  Anders Carlsson  <andersca@apple.com>
    221
  • trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp

    r157163 r159092  
    7979        if (node->isHTMLElement())
    8080            return WEBKIT_DOM_NODE(wrap(toHTMLElement(node)));
    81         return WEBKIT_DOM_NODE(wrapElement(static_cast<Element*>(node)));
     81        return WEBKIT_DOM_NODE(wrapElement(toElement(node)));
    8282    case Node::ATTRIBUTE_NODE:
    8383        return WEBKIT_DOM_NODE(wrapAttr(static_cast<Attr*>(node)));
  • trunk/Source/WebCore/dom/ElementTraversal.h

    r158587 r159092  
    110110    while (node && !node->isElementNode())
    111111        node = NodeTraversal::previous(node, current);
    112     return static_cast<Element*>(node);
     112    return toElement(node);
    113113}
    114114
     
    120120    while (node && !node->isElementNode())
    121121        node = NodeTraversal::nextSkippingChildren(node);
    122     return static_cast<Element*>(node);
     122    return toElement(node);
    123123}
    124124
     
    130130    while (node && !node->isElementNode())
    131131        node = NodeTraversal::nextSkippingChildren(node, stayWithin);
    132     return static_cast<Element*>(node);
     132    return toElement(node);
    133133}
    134134
     
    140140    while (node && !node->isElementNode())
    141141        node = NodeTraversal::previous(node);
    142     return static_cast<Element*>(node);
     142    return toElement(node);
    143143}
    144144
     
    150150    while (node && !node->isElementNode())
    151151        node = NodeTraversal::previous(node, stayWithin);
    152     return static_cast<Element*>(node);
     152    return toElement(node);
    153153}
    154154
Note: See TracChangeset for help on using the changeset viewer.