Changeset 159352 in webkit
- Timestamp:
- Nov 15, 2013 12:28:08 PM (10 years ago)
- Location:
- trunk/Tools
- Files:
-
- 1 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js
r156736 r159352 24 24 */ 25 25 26 var settings = new Settings; 26 27 var buildbot = new WebKitBuildbot; -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js
r158151 r159352 71 71 return a.order - b.order; 72 72 }); 73 73 74 74 return platforms; 75 } 76 77 function updateHiddenPlatforms() 78 { 79 var hiddenPlatforms = settings.getObject("hiddenPlatforms"); 80 if (!hiddenPlatforms) 81 hiddenPlatforms = []; 82 83 var platformRows = document.querySelectorAll("tr.platform"); 84 for (var i = 0; i < platformRows.length; ++i) 85 platformRows[i].classList.remove("hidden"); 86 87 for (var i = 0; i < hiddenPlatforms.length; ++i) 88 document.querySelector("tr.platform." + hiddenPlatforms[i]).classList.add("hidden"); 89 90 var unhideButton = document.querySelector("div.cellButton.unhide"); 91 if (hiddenPlatforms.length) 92 unhideButton.classList.remove("hidden"); 93 else 94 unhideButton.classList.add("hidden"); 75 95 } 76 96 … … 83 103 row.classList.add("headers"); 84 104 85 // Empty header for the platform logo.86 105 var header = document.createElement("th"); 106 var unhideButton = document.createElement("div"); 107 unhideButton.addEventListener("click", function () { settings.clearHiddenPlatforms(); }); 108 unhideButton.textContent = "Show All Platforms"; 109 unhideButton.classList.add("cellButton", "unhide", "hidden"); 110 header.appendChild(unhideButton); 87 111 row.appendChild(header); 88 112 … … 123 147 cell.appendChild(logoImage); 124 148 149 var hideButton = document.createElement("div"); 150 hideButton.addEventListener("click", function (platformName) { return function () { settings.toggleHiddenPlatform(platformName); }; }(platform.name) ); 151 hideButton.textContent = "hide"; 152 hideButton.classList.add("cellButton", "hide"); 153 cell.appendChild(hideButton); 154 125 155 row.appendChild(cell); 126 156 … … 147 177 148 178 document.body.appendChild(table); 179 180 updateHiddenPlatforms(); 181 settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms); 149 182 } 150 183 -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
r159342 r159352 37 37 .selectable { 38 38 -webkit-user-select: all; 39 } 40 41 div.cellButton { 42 font-family: "HelveticaNeue-Light", sans-serif; 43 font-size: 12px; 44 color: rgb(185, 175, 125); 45 cursor: pointer; 46 } 47 48 div.cellButton.hide { 49 position: absolute; 50 bottom: 2px; 51 right: 4px; 52 } 53 54 .hidden { 55 display: none; 39 56 } 40 57 -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html
r156750 r159352 45 45 <script src="Scripts/BuildbotTesterQueueView.js"></script> 46 46 <script src="Scripts/StatusLineView.js"></script> 47 <script src="Scripts/Settings.js"></script> 47 48 <script src="Scripts/Initialization.js"></script> 48 49 <script src="Scripts/Main.js"></script> -
trunk/Tools/ChangeLog
r159343 r159352 1 2013-11-15 Tim Horton <timothy_horton@apple.com> 2 3 build.webkit.org/dashboard should provide a way to focus on a subset of bots 4 https://bugs.webkit.org/show_bug.cgi?id=122676 5 6 Reviewed by Timothy Hatcher. 7 8 Add a small 'hide' button next to every platform logo, and a 'show all' 9 button which only appears when at least one platform is hidden. Hidden 10 platforms persist using localStorage. 11 12 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: 13 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: 14 (updateHiddenPlatforms): 15 (documentReady.unhideButton): 16 (documentReady.hideButton): 17 (documentReady): 18 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added. 19 (Settings.prototype.setObject): 20 (Settings.prototype.getObject): 21 (Settings.prototype.addSettingListener): 22 (Settings.prototype.fireSettingListener): 23 (Settings.prototype.toggleHiddenPlatform): 24 (Settings.prototype.clearHiddenPlatforms): 25 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: 26 (div.cellButton): 27 (div.cellButton.hide): 28 (.hidden): 29 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: 30 1 31 2013-11-15 Jer Noble <jer.noble@apple.com> 2 32
Note: See TracChangeset
for help on using the changeset viewer.