Changeset 159925 in webkit


Ignore:
Timestamp:
Dec 2, 2013 2:40:07 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

[ATK] Support active state for listbox elements.
​https://bugs.webkit.org/show_bug.cgi?id=125009

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2013-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ATK_STATE_ACTIVE for listbox elements.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

Establish expectations for the test (all PASS).

  • accessibility/multiselect-list-reports-active-option-expected.txt: Added.
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
Location:
trunk
Files:
1 added
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r159870 r159925  
     12013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
     2
     3        [ATK] Support active state for listbox elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=125009
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Establish expectations for the test (all PASS).
     9
     10        * accessibility/multiselect-list-reports-active-option-expected.txt: Added.
     11        * platform/efl-wk1/TestExpectations:
     12        * platform/efl-wk2/TestExpectations:
     13
    1142013-11-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
    215

  • trunk/LayoutTests/platform/efl-wk1/TestExpectations

    r159742 r159925  
    137137accessibility/img-fallsback-to-title.html [ Skip ]
    138138accessibility/internal-link-anchors2.html [ Skip ]
    139 accessibility/multiselect-list-reports-active-option.html [ Skip ]
    140139accessibility/radio-button-group-members.html [ Skip ]
    141140accessibility/table-cell-spans.html [ Skip ]

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r159812 r159925  
    172172webkit.org/b/118418 accessibility/img-fallsback-to-title.html [ Missing ]
    173173webkit.org/b/98348  accessibility/internal-link-anchors2.html [ Missing ]
    174 webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Missing ]
    175174webkit.org/b/98348  accessibility/radio-button-group-members.html [ Missing ]
    176175

  • trunk/Source/WebCore/ChangeLog

    r159923 r159925  
     12013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
     2
     3        [ATK] Support active state for listbox elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=125009
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Added support for ATK_STATE_ACTIVE for listbox elements.
     9
     10        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     11        (setAtkStateSetFromCoreObject):
     12
    1132013-12-02  Seokju Kwon  <seokju@webkit.org>
    214

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r158841 r159925  
    707707
    708708    // Please keep the state list in alphabetical order
     709    if (isListBoxOption && coreObject->isSelectedOptionActive())
     710        atk_state_set_add_state(stateSet, ATK_STATE_ACTIVE);
     711
    709712    if (coreObject->isChecked())
    710713        atk_state_set_add_state(stateSet, ATK_STATE_CHECKED);

  • trunk/Tools/ChangeLog

    r159924 r159925  
     12013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
     2
     3        [ATK] Support active state for listbox elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=125009
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
     9
     10        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
     11        (AccessibilityUIElement::isSelectedOptionActive):
     12        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
     13        (WTR::AccessibilityUIElement::isSelectedOptionActive):
     14        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
     15        * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
     16        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     17        (WTR::AccessibilityUIElement::isSelectedOptionActive):
     18        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
     19        (WTR::AccessibilityUIElement::isSelectedOptionActive):
     20
    1212013-12-02  Zan Dobersek  <zdobersek@igalia.com>
    222

  • trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp

    r159867 r159925  
    13471347bool AccessibilityUIElement::isSelectedOptionActive() const
    13481348{
    1349     // FIXME: implement
    1350     return false;
     1349    return checkElementState(m_element, ATK_STATE_ACTIVE);
    13511350}
    13521351

  • trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp

    r159468 r159925  
    115115bool AccessibilityUIElement::isFocusable() const { return false; }
    116116bool AccessibilityUIElement::isSelected() const { return false; }
     117bool AccessibilityUIElement::isSelectedOptionActive() const { return false; }
    117118bool AccessibilityUIElement::isSelectable() const { return false; }
    118119bool AccessibilityUIElement::isMultiSelectable() const { return false; }

  • trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h

    r159468 r159925  
    137137    bool isFocusable() const;
    138138    bool isSelected() const;
     139    bool isSelectedOptionActive() const;
    139140    bool isSelectable() const;
    140141    bool isMultiSelectable() const;

  • trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl

    r159468 r159925  
    7777    readonly attribute boolean isSelectable;
    7878    readonly attribute boolean isSelected;
     79    readonly attribute boolean isSelectedOptionActive;
    7980    readonly attribute boolean isMultiSelectable;
    8081    readonly attribute boolean isExpanded;

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r159867 r159925  
    10641064}
    10651065
     1066bool AccessibilityUIElement::isSelectedOptionActive() const
     1067{
     1068    return checkElementState(m_element.get(), ATK_STATE_ACTIVE);
     1069}
     1070
    10661071bool AccessibilityUIElement::isExpanded() const
    10671072{

  • trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

    r159468 r159925  
    795795    END_AX_OBJC_EXCEPTIONS
    796796   
     797    return false;
     798}
     799
     800bool AccessibilityUIElement::isSelectedOptionActive() const
     801{
     802    // FIXME: implement
    797803    return false;
    798804}
Note: See TracChangeset for help on using the changeset viewer.