Changeset 159999 in webkit

Timestamp:

Dec 3, 2013 4:42:29 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Correct broken build on efl port with --no-netscape-plugin-api
configuration.
​https://bugs.webkit.org/show_bug.cgi?id=123997

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-12-03
Reviewed by Zoltan Herczeg.

Build failed on efl port with --no-netscape-plugin-api configuration
as ld did not found some methods. The configuration uses a minimal
empty implementation of the class, which is now extended with empty
method implementations.

• plugins/PluginPackageNone.cpp:

(WebCore::PluginPackage::createPackage):

Returns NULL pointer.

(WebCore::PluginPackage::hash):

Returns 0.

(WebCore::PluginPackage::equal):

Returns true (equals).

(WebCore::PluginPackage::compare):

Returns 0 (equals).

(WebCore::PluginPackage::~PluginPackage):

Do nothing.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginPackageNone.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-03  Tamas Gergely  <gertom@inf.u-szeged.hu>
+
+        Correct broken build on efl port with --no-netscape-plugin-api
+        configuration.
+        https://bugs.webkit.org/show_bug.cgi?id=123997
+
+        Reviewed by Zoltan Herczeg.
+
+        Build failed on efl port with --no-netscape-plugin-api configuration
+        as ld did not found some methods. The configuration uses a minimal
+        empty implementation of the class, which is now extended with empty
+        method implementations.
+
+        * plugins/PluginPackageNone.cpp:
+        (WebCore::PluginPackage::createPackage):
+          Returns NULL pointer.
+        (WebCore::PluginPackage::hash):
+          Returns 0.
+        (WebCore::PluginPackage::equal):
+          Returns true (equals).
+        (WebCore::PluginPackage::compare):
+          Returns 0 (equals).
+        (WebCore::PluginPackage::~PluginPackage):
+          Do nothing.
+
 2013-12-02  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/plugins/PluginPackageNone.cpp

@@ -50 +50 @@
 #endif
 
+PassRefPtr<PluginPackage> PluginPackage::createPackage(const String&, const time_t&)
+{
+    return 0;
 }
+
+unsigned PluginPackage::hash() const
+{
+    return 0;
+}
+
+bool PluginPackage::equal(const PluginPackage&, const PluginPackage&)
+{
+    return true;
+}
+
+int PluginPackage::compare(const PluginPackage&) const
+{
+    return 0;
+}
+
+PluginPackage::~PluginPackage()
+{
+}
+
+}