Changeset 160021 in webkit

Timestamp:

Dec 3, 2013 11:37:24 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Checking second-to-last bit in address is a typo
​https://bugs.webkit.org/show_bug.cgi?id=125162

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-12-03
Reviewed by Darin Adler.

After talking with the original author of this line,
is was a typo to make sure that the second-to-last bit
in an address is 0. Instead, we want to make sure that
the address is aligned to a 4-byte boundary

No behavior change, so no test is necessary

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cg/ImageBufferCG.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-03  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Checking second-to-last bit in address is a typo
+        https://bugs.webkit.org/show_bug.cgi?id=125162
+
+        Reviewed by Darin Adler.
+
+        After talking with the original author of this line,
+        is was a typo to make sure that the second-to-last bit
+        in an address is 0. Instead, we want to make sure that
+        the address is aligned to a 4-byte boundary
+
+        No behavior change, so no test is necessary
+
+        * platform/graphics/cg/ImageBufferCG.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+
 2013-12-03  Radu Stavila  <stavila@adobe.com>
 

trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp

@@ -159 +159 @@
         if (!tryFastCalloc(height.unsafeGet(), m_data.m_bytesPerRow.unsafeGet()).getValue(m_data.m_data))
             return;
-        ASSERT(!(reinterpret_cast<size_t>(m_data.m_data) & 2));
+        ASSERT(!(reinterpret_cast<intptr_t>(m_data.m_data) & 3));
 
         m_data.m_bitmapInfo = kCGImageAlphaPremultipliedLast;