Changeset 160379 in webkit


Ignore:
Timestamp:
Dec 10, 2013 12:11:18 PM (10 years ago)
Author:
mario.prada@samsung.com
Message:

[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
​https://bugs.webkit.org/show_bug.cgi?id=125521

Reviewed by Chris Fleizach.

Source/WebCore:

Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
ATK_ROLE_ALERT instead.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Update expected result in layout test.

  • accessibility/aria-mappings-expected.txt:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r160374 r160379  
     12013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
     4        https://bugs.webkit.org/show_bug.cgi?id=125521
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Update expected result in layout test.
     9
     10        * accessibility/aria-mappings-expected.txt:
     11
    1122013-12-10  László Langó  <lango@inf.u-szeged.hu>
    213

  • trunk/LayoutTests/accessibility/aria-mappings-expected.txt

    r160220 r160379  
    2222
    2323role="alertdialog" is a dialog which contains an alert message.
    24 Role for 'alertdialog' div is: AXRole: AXDialog
     24Role for 'alertdialog' div is: AXRole: AXAlert
    2525
    2626

  • trunk/Source/WebCore/ChangeLog

    r160375 r160379  
     12013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
     4        https://bugs.webkit.org/show_bug.cgi?id=125521
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
     9        ATK_ROLE_ALERT instead.
     10
     11        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     12        (atkRole):
     13
    1142013-12-10  Brendan Long  <b.long@cablelabs.com>
    215

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r160220 r160379  
    535535{
    536536    switch (role) {
     537    case ApplicationAlertDialogRole:
    537538    case ApplicationAlertRole:
    538539        return ATK_ROLE_ALERT;
    539540    case ApplicationDialogRole:
    540     case ApplicationAlertDialogRole:
    541541        return ATK_ROLE_DIALOG;
    542542    case ApplicationStatusRole:
Note: See TracChangeset for help on using the changeset viewer.