Changeset 160389 in webkit

Timestamp:

Dec 10, 2013 2:28:06 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Clean up SVGScriptElement
​https://bugs.webkit.org/show_bug.cgi?id=125527

Patch by Rob Buis <​rob.buis@samsung.com> on 2013-12-10
Reviewed by Sam Weinig.

Rewrite to not store type in m_type and also remove type getter/setter.

• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::typeAttributeValue):

• svg/SVGScriptElement.h:
• svg/SVGScriptElement.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGScriptElement.cpp (modified) (3 diffs)
• svg/SVGScriptElement.h (modified) (2 diffs)
• svg/SVGScriptElement.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-10  Rob Buis  <rob.buis@samsung.com>
+
+        Clean up SVGScriptElement
+        https://bugs.webkit.org/show_bug.cgi?id=125527
+
+        Reviewed by Sam Weinig.
+
+        Rewrite to not store type in m_type and also remove type getter/setter.
+
+        * svg/SVGScriptElement.cpp:
+        (WebCore::SVGScriptElement::parseAttribute):
+        (WebCore::SVGScriptElement::typeAttributeValue):
+        * svg/SVGScriptElement.h:
+        * svg/SVGScriptElement.idl:
+
 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
 

trunk/Source/WebCore/svg/SVGScriptElement.cpp

@@ -77 +77 @@
     }
 
-    if (name == SVGNames::typeAttr) {
-        setType(value);
-        return;
-    }
+    if (name == SVGNames::typeAttr)
+        return;
 
     if (name == HTMLNames::onerrorAttr) {
@@ -144 +142 @@
 }
 
-String SVGScriptElement::type() const
-{
-    return m_type;
-}
-
-void SVGScriptElement::setType(const String& type)
-{
-    m_type = type;
-}
-
 void SVGScriptElement::addSubresourceAttributeURLs(ListHashSet<URL>& urls) const
 {
@@ -173 +161 @@
 String SVGScriptElement::typeAttributeValue() const
 {
-    return type();
+    return fastGetAttribute(SVGNames::typeAttr).string();
 }
 

trunk/Source/WebCore/svg/SVGScriptElement.h

@@ -39 +39 @@
     static PassRefPtr<SVGScriptElement> create(const QualifiedName&, Document&, bool wasInsertedByParser);
 
-    String type() const;
-    void setType(const String&);
 
 private:
@@ -84 +82 @@
     END_DECLARE_ANIMATED_PROPERTIES
 
-    String m_type;
     Timer<SVGElement> m_svgLoadEventTimer;
 };

trunk/Source/WebCore/svg/SVGScriptElement.idl

@@ -27 +27 @@
     Conditional=SVG
 ] interface SVGScriptElement : SVGElement {
-    [TreatNullAs=NullString] attribute DOMString type;
+    [TreatNullAs=NullString, Reflect] attribute DOMString type;
 };