Changeset 160498 in webkit

Timestamp:

Dec 12, 2013 11:22:55 AM (10 years ago)

Author:

akling@apple.com

Message:

[Mac] Stop not caching HTTP resources with "Vary" header in response.
<​https://webkit.org/b/125483>
<rdar://problem/11781097>

Remove the workaround preventing resources with the "Vary" header
from going into cache, as the CFNetwork cache has supported this
for quite a while now.

31.5 MB progression on Membuster3, because we can now mmap those
resources from disk once they are in the cache.

We keep the workaround on PLATFORM(WIN) for now.

Reviewed by Antti Koivisto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/WebCoreResourceHandleAsDelegate.mm (modified) (1 diff)
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-12  Andreas Kling  <akling@apple.com>
+
+        [Mac] Stop not caching HTTP resources with "Vary" header in response.
+        <https://webkit.org/b/125483>
+        <rdar://problem/11781097>
+
+        Remove the workaround preventing resources with the "Vary" header
+        from going into cache, as the CFNetwork cache has supported this
+        for quite a while now.
+
+        31.5 MB progression on Membuster3, because we can now mmap those
+        resources from disk once they are in the cache.
+
+        We keep the workaround on PLATFORM(WIN) for now.
+
+        Reviewed by Antti Koivisto.
+
 2013-12-12  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm

@@ -256 +256 @@
         return nil;
 
-    // Workaround for <rdar://problem/6300990> Caching does not respect Vary HTTP header.
-    // FIXME: WebCore cache has issues with Vary, too (bug 58797, bug 71509).
-    if ([[cachedResponse response] isKindOfClass:[NSHTTPURLResponse class]]
-        && [[(NSHTTPURLResponse *)[cachedResponse response] allHeaderFields] objectForKey:@"Vary"])
-        return nil;
-
     return m_handle->client()->willCacheResponse(m_handle, cachedResponse);
 }

trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm

@@ -370 +370 @@
         }
 
-        // Workaround for <rdar://problem/6300990> Caching does not respect Vary HTTP header.
-        // FIXME: WebCore cache has issues with Vary, too (bug 58797, bug 71509).
-        if ([[cachedResponse response] isKindOfClass:[NSHTTPURLResponse class]]
-            && [[(NSHTTPURLResponse *)[cachedResponse response] allHeaderFields] objectForKey:@"Vary"]) {
-            m_cachedResponseResult = nullptr;
-            dispatch_semaphore_signal(m_semaphore);
-            return;
-        }
-
         m_handle->client()->willCacheResponseAsync(m_handle, cachedResponse);
     });