Changeset 160523 in webkit
- Timestamp:
- Dec 12, 2013 6:19:25 PM (10 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r160494 r160523 1 2013-12-12 Joseph Pecoraro <pecoraro@apple.com> 2 3 Add a few more ASCIILiterals 4 https://bugs.webkit.org/show_bug.cgi?id=125662 5 6 Reviewed by Darin Adler. 7 8 * inspector/InspectorBackendDispatcher.cpp: 9 (Inspector::InspectorBackendDispatcher::dispatch): 10 1 11 2013-12-12 Joseph Pecoraro <pecoraro@apple.com> 2 12 -
trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp
r160457 r160523 81 81 RefPtr<InspectorValue> parsedMessage = InspectorValue::parseJSON(message); 82 82 if (!parsedMessage) { 83 reportProtocolError(nullptr, ParseError, "Message must be in JSON format");83 reportProtocolError(nullptr, ParseError, ASCIILiteral("Message must be in JSON format")); 84 84 return; 85 85 } … … 87 87 RefPtr<InspectorObject> messageObject = parsedMessage->asObject(); 88 88 if (!messageObject) { 89 reportProtocolError(nullptr, InvalidRequest, "Message must be a JSONified object");89 reportProtocolError(nullptr, InvalidRequest, ASCIILiteral("Message must be a JSONified object")); 90 90 return; 91 91 } … … 93 93 RefPtr<InspectorValue> callIdValue = messageObject->get("id"); 94 94 if (!callIdValue) { 95 reportProtocolError(nullptr, InvalidRequest, "'id' property was not found");95 reportProtocolError(nullptr, InvalidRequest, ASCIILiteral("'id' property was not found")); 96 96 return; 97 97 } … … 99 99 long callId = 0; 100 100 if (!callIdValue->asNumber(&callId)) { 101 reportProtocolError(nullptr, InvalidRequest, "The type of 'id' property must be number");101 reportProtocolError(nullptr, InvalidRequest, ASCIILiteral("The type of 'id' property must be number")); 102 102 return; 103 103 } … … 105 105 RefPtr<InspectorValue> methodValue = messageObject->get("method"); 106 106 if (!methodValue) { 107 reportProtocolError(&callId, InvalidRequest, "'method' property wasn't found");107 reportProtocolError(&callId, InvalidRequest, ASCIILiteral("'method' property wasn't found")); 108 108 return; 109 109 } … … 111 111 String method; 112 112 if (!methodValue->asString(&method)) { 113 reportProtocolError(&callId, InvalidRequest, "The type of 'method' property must be string");113 reportProtocolError(&callId, InvalidRequest, ASCIILiteral("The type of 'method' property must be string")); 114 114 return; 115 115 } … … 117 117 size_t position = method.find('.'); 118 118 if (position == WTF::notFound) { 119 reportProtocolError(&callId, InvalidRequest, "The 'method' property was formatted incorrectly. It should be 'Domain.method'");119 reportProtocolError(&callId, InvalidRequest, ASCIILiteral("The 'method' property was formatted incorrectly. It should be 'Domain.method'")); 120 120 return; 121 121 }
Note: See TracChangeset
for help on using the changeset viewer.