Changeset 160585 in webkit
- Timestamp:
- Dec 13, 2013 8:55:55 PM (10 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r160557 r160585 1 2013-12-13 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: Exception: TypeError: undefined is not a function (evaluating 'marker.find()') 4 https://bugs.webkit.org/show_bug.cgi?id=125724 5 6 Reviewed by Darin Adler. 7 8 * UserInterface/CSSStyleDeclarationTextEditor.js: 9 (WebInspector.CSSStyleDeclarationTextEditor.prototype.): 10 (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches): 11 The callback changed to returning WebInspector.TextMarkers, however 12 this class expected a raw CodeMirror marker. Since this class knows 13 about CodeMirror and expects to access these markers later go 14 directly to the CodeMirror marker. 15 1 16 2013-12-13 Joseph Pecoraro <pecoraro@apple.com> 2 17 -
trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js
r160483 r160585 401 401 swatchInnerElement.style.backgroundColor = colorString; 402 402 swatchElement.appendChild(swatchInnerElement); 403 404 var swatchMarker = this._codeMirror.setUniqueBookmark(marker.find().from, swatchElement); 405 406 swatchInnerElement.__colorTextMarker = marker; 403 404 var codeMirrorTextMarker = marker.codeMirrorTextMarker; 405 var swatchMarker = this._codeMirror.setUniqueBookmark(codeMirrorTextMarker.find().from, swatchElement); 406 407 swatchInnerElement.__colorTextMarker = codeMirrorTextMarker; 407 408 swatchInnerElement.__color = color; 408 409 }.bind(this));
Note: See TracChangeset
for help on using the changeset viewer.