Changeset 160849 in webkit

Timestamp:

Dec 19, 2013 11:42:22 AM (10 years ago)

Author:

eric.carlson@apple.com

Message:

tryAddEventListener uses local PassRefPtr<>
​https://bugs.webkit.org/show_bug.cgi?id=126001

Reviewed by Daniel Bates.

• dom/Node.cpp:

(WebCore::tryAddEventListener): Put PassRefPtr<EventListener> parameter into a local RefPtr

because it is sometimes used twice.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Node.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-19  Eric Carlson  <eric.carlson@apple.com>
+
+        tryAddEventListener uses local PassRefPtr<>
+        https://bugs.webkit.org/show_bug.cgi?id=126001
+
+        Reviewed by Daniel Bates.
+
+        * dom/Node.cpp:
+        (WebCore::tryAddEventListener): Put PassRefPtr<EventListener> parameter into a local RefPtr
+            because it is sometimes used twice.
+
 2013-12-19  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/dom/Node.cpp

@@ -1786 +1786 @@
 }
 
-static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
-{
+static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtr<EventListener> prpListener, bool useCapture)
+{
+    RefPtr<EventListener> listener = prpListener;
+
     if (!targetNode->EventTarget::addEventListener(eventType, listener, useCapture))
         return false;