Changeset 160876 in webkit

Timestamp:

Dec 19, 2013 4:42:47 PM (10 years ago)

Author:

Brent Fulgham

Message:

Implement ArrayBuffer.isView
​https://bugs.webkit.org/show_bug.cgi?id=126004

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Test coverage in webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html

• runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation): Add 'isView' to object constructor.
(JSC::arrayBufferFuncIsView): New method.

LayoutTests:

• webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:

Correct test for 'isView' to actually check for 'isView' function.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/CommonIdentifiers.h (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-12-19  Brent Fulgham  <bfulgham@apple.com>
+
+        Implement ArrayBuffer.isView
+        https://bugs.webkit.org/show_bug.cgi?id=126004
+
+        Reviewed by Filip Pizlo.
+
+        * webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
+        Correct test for 'isView' to actually check for 'isView' function.
+
 2013-12-19  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html

@@ -149 +149 @@
 
   try {
-    if (!ArrayBuffer.create) {
+    if (!ArrayBuffer.isView) {
       testFailed('ArrayBuffer.isView() method does not exist');
     } else {

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-12-19  Brent Fulgham  <bfulgham@apple.com>
+
+        Implement ArrayBuffer.isView
+        https://bugs.webkit.org/show_bug.cgi?id=126004
+
+        Reviewed by Filip Pizlo.
+
+        Test coverage in webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html
+
+        * runtime/JSArrayBufferConstructor.cpp:
+        (JSC::JSArrayBufferConstructor::finishCreation): Add 'isView' to object constructor.
+        (JSC::arrayBufferFuncIsView): New method.
+
 2013-12-19  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -113 +113 @@
     macro(isArray) \
     macro(isPrototypeOf) \
+    macro(isView) \
     macro(isWatchpoint) \
     macro(join) \

trunk/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp

@@ -36 +36 @@
 namespace JSC {
 
+static EncodedJSValue JSC_HOST_CALL arrayBufferFuncIsView(ExecState*);
+
 const ClassInfo JSArrayBufferConstructor::s_info = {
     "Function", &Base::s_info, 0, 0,
@@ -51 +53 @@
     putDirectWithoutTransition(vm, vm.propertyNames->prototype, prototype, DontEnum | DontDelete | ReadOnly);
     putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(1), DontEnum | DontDelete | ReadOnly);
+
+    JSGlobalObject* globalObject = this->globalObject();
+    JSC_NATIVE_FUNCTION(vm.propertyNames->isView, arrayBufferFuncIsView, DontEnum, 1);
 }
 
@@ -109 +114 @@
 }
 
+// ------------------------------ Functions --------------------------------
+
+// ECMA 24.1.3.1
+EncodedJSValue JSC_HOST_CALL arrayBufferFuncIsView(ExecState* exec)
+{
+    return JSValue::encode(jsBoolean(jsDynamicCast<JSArrayBufferView*>(exec->argument(0))));
+}
+    
+
 } // namespace JSC