Changeset 160904 in webkit

Timestamp:

Dec 20, 2013 4:11:45 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Some unit tests using web extensions fail when run alone
​https://bugs.webkit.org/show_bug.cgi?id=126002

Reviewed by Gustavo Noronha Silva.

The problem is that the page is created before the dbus connection
has been established, and we are connecting to web-page-created
signal once we have a valid dbus connection. We should connect to
the signal before connecting to dbus and queue any request to emit
a dbus signal until the connection is set. This also fixes the
WebExtensions tests when using the network process because a new
web process is launched for every test case.

• UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(DelayedSignal::DelayedSignal): Helper struct to queue signal
emissions requested before the dbus connection has been
established.
(emitDocumentLoaded): Emit the dbus DocumentLoaded signal.
(documentLoadedCallback): Queue the signal emission if we still
don't have a connection or call emitDocumentLoaded otherwise.
(emitURIChanged): Emit the dbus URIChanged signal.
(uriChangedCallback): Queue the signal emission if we still don't
have a connection or call emitURIChanged otherwise.
(pageCreatedCallback): Pass the web extension as user data to
document-loaded and uri-changed callbacks.
(busAcquiredCallback): Set the connection as user data of the web
extension and process any delayed signal emission pending.
(webkit_web_extension_initialize): Connect to web-page-create
signal before connecting to dbus.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/tests/WebExtensionTest.cpp (modified) (5 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Some unit tests using web extensions fail when run alone
+        https://bugs.webkit.org/show_bug.cgi?id=126002
+
+        Reviewed by Gustavo Noronha Silva.
+
+        The problem is that the page is created before the dbus connection
+        has been established, and we are connecting to web-page-created
+        signal once we have a valid dbus connection. We should connect to
+        the signal before connecting to dbus and queue any request to emit
+        a dbus signal until the connection is set. This also fixes the
+        WebExtensions tests when using the network process because a new
+        web process is launched for every test case.
+
+        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
+        (DelayedSignal::DelayedSignal): Helper struct to queue signal
+        emissions requested before the dbus connection has been
+        established.
+        (emitDocumentLoaded): Emit the dbus DocumentLoaded signal.
+        (documentLoadedCallback): Queue the signal emission if we still
+        don't have a connection or call emitDocumentLoaded otherwise.
+        (emitURIChanged): Emit the dbus URIChanged signal.
+        (uriChangedCallback): Queue the signal emission if we still don't
+        have a connection or call emitURIChanged otherwise.
+        (pageCreatedCallback): Pass the web extension as user data to
+        document-loaded and uri-changed callbacks.
+        (busAcquiredCallback): Set the connection as user data of the web
+        extension and process any delayed signal emission pending.
+        (webkit_web_extension_initialize): Connect to web-page-create
+        signal before connecting to dbus.
+
 2013-12-19  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp

@@ -26 +26 @@
 #include <string.h>
 #include <webkit2/webkit-web-extension.h>
+#include <wtf/Deque.h>
+#include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
 #include <wtf/gobject/GOwnPtr.h>
 #include <wtf/gobject/GRefPtr.h>
+#include <wtf/text/CString.h>
 
 static const char introspectionXML[] =
@@ -49 +53 @@
     "</node>";
 
-static void documentLoadedCallback(WebKitWebPage*, gpointer userData)
-{
-    bool ok = g_dbus_connection_emit_signal(G_DBUS_CONNECTION(userData),
+typedef enum {
+    DocumentLoadedSignal,
+    URIChangedSignal,
+} DelayedSignalType;
+
+struct DelayedSignal {
+    DelayedSignal(DelayedSignalType type)
+        : type(type)
+    {
+    }
+
+    DelayedSignal(DelayedSignalType type, const char* uri)
+        : type(type)
+        , uri(uri)
+    {
+    }
+
+    DelayedSignalType type;
+    CString uri;
+};
+
+Deque<OwnPtr<DelayedSignal>> delayedSignalsQueue;
+
+static void emitDocumentLoaded(GDBusConnection* connection)
+{
+    bool ok = g_dbus_connection_emit_signal(
+        connection,
         0,
         "/org/webkit/gtk/WebExtensionTest",
@@ -61 +89 @@
 }
 
-static void uriChangedCallback(WebKitWebPage* webPage, GParamSpec* pspec, gpointer userData)
+static void documentLoadedCallback(WebKitWebPage*, WebKitWebExtension* extension)
+{
+    gpointer data = g_object_get_data(G_OBJECT(extension), "dbus-connection");
+    if (data)
+        emitDocumentLoaded(G_DBUS_CONNECTION(data));
+    else
+        delayedSignalsQueue.append(adoptPtr(new DelayedSignal(DocumentLoadedSignal)));
+}
+
+static void emitURIChanged(GDBusConnection* connection, const char* uri)
 {
     bool ok = g_dbus_connection_emit_signal(
-        G_DBUS_CONNECTION(userData),
+        connection,
         0,
         "/org/webkit/gtk/WebExtensionTest",
         "org.webkit.gtk.WebExtensionTest",
         "URIChanged",
-        g_variant_new("(s)", webkit_web_page_get_uri(webPage)),
+        g_variant_new("(s)", uri),
         0);
     g_assert(ok);
+}
+
+static void uriChangedCallback(WebKitWebPage* webPage, GParamSpec* pspec, WebKitWebExtension* extension)
+{
+    gpointer data = g_object_get_data(G_OBJECT(extension), "dbus-connection");
+    if (data)
+        emitURIChanged(G_DBUS_CONNECTION(data), webkit_web_page_get_uri(webPage));
+    else
+        delayedSignalsQueue.append(adoptPtr(new DelayedSignal(URIChangedSignal, webkit_web_page_get_uri(webPage))));
 }
 
@@ -93 +139 @@
 }
 
-static void pageCreatedCallback(WebKitWebExtension*, WebKitWebPage* webPage, gpointer userData)
-{
-    g_signal_connect(webPage, "document-loaded", G_CALLBACK(documentLoadedCallback), userData);
-    g_signal_connect(webPage, "notify::uri", G_CALLBACK(uriChangedCallback), userData);
+static void pageCreatedCallback(WebKitWebExtension* extension, WebKitWebPage* webPage, gpointer)
+{
+    g_signal_connect(webPage, "document-loaded", G_CALLBACK(documentLoadedCallback), extension);
+    g_signal_connect(webPage, "notify::uri", G_CALLBACK(uriChangedCallback), extension);
     g_signal_connect(webPage, "send-request", G_CALLBACK(sendRequestCallback), 0);
 }
@@ -192 +238 @@
         g_warning("Failed to register object: %s\n", error->message);
 
-    g_signal_connect(WEBKIT_WEB_EXTENSION(userData), "page-created", G_CALLBACK(pageCreatedCallback), connection);
+    g_object_set_data(G_OBJECT(userData), "dbus-connection", connection);
+    while (delayedSignalsQueue.size()) {
+        OwnPtr<DelayedSignal> delayedSignal = delayedSignalsQueue.takeFirst();
+        switch (delayedSignal->type) {
+        case DocumentLoadedSignal:
+            emitDocumentLoaded(connection);
+            break;
+        case URIChangedSignal:
+            emitURIChanged(connection, delayedSignal->uri.data());
+            break;
+        }
+    }
+}
+
+extern "C" void webkit_web_extension_initialize(WebKitWebExtension* extension)
+{
+    g_signal_connect(extension, "page-created", G_CALLBACK(pageCreatedCallback), extension);
     g_signal_connect(webkit_script_world_get_default(), "window-object-cleared", G_CALLBACK(windowObjectCleared), 0);
-}
-
-extern "C" void webkit_web_extension_initialize(WebKitWebExtension* extension)
-{
+
     g_bus_own_name(
         G_BUS_TYPE_SESSION,