Changeset 161497 in webkit


Ignore:
Timestamp:
Jan 8, 2014 7:13:06 AM (10 years ago)
Author:
zandobersek@gmail.com
Message:

[Automake] Scripts for generated build targets do not necessarily produce their output
https://bugs.webkit.org/show_bug.cgi?id=126378

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

  • GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't

assure the output is generated every time the script is invoked, most commonly due to unchanged
input. This assures the build targets are up-to-date and can't be older that their dependencies,
which would result in constant regeneration at every build.

Source/WebCore:

  • GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't

assure the output is generated every time the script is invoked, most commonly due to unchanged

  • bindings/gobject/GNUmakefile.am: Simply move the gdom-gen-symbols file into the output file

instead of copying it if the contents differ and removing it. This again ensures that the output
file is always newer than its dependencies, even if the input hasn't changed.

Source/WebKit2:

  • GNUmakefile.am: Don't pass the -n option to the ln command that links the build's include

directories to actual source directories. This doesn't replace the original symbolic link,
which can lead to the actual link being older than its dependencies and subsequent constant
relinking at every build.

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r161465 r161497  
     12014-01-08  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [Automake] Scripts for generated build targets do not necessarily produce their output
     4        https://bugs.webkit.org/show_bug.cgi?id=126378
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        * GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't
     9        assure the output is generated every time the script is invoked, most commonly due to unchanged
     10        input. This assures the build targets are up-to-date and can't be older that their dependencies,
     11        which would result in constant regeneration at every build.
     12
    1132014-01-07  Filip Pizlo  <fpizlo@apple.com>
    214
  • trunk/Source/JavaScriptCore/GNUmakefile.am

    r161255 r161497  
    9696DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h: $(javascriptcore_sources) $(llint_nosources) $(offlineasm_nosources)
    9797        $(AM_V_GEN)$(RUBY) $(srcdir)/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb $(srcdir)/Source/JavaScriptCore/llint/LowLevelInterpreter.asm $@
     98        $(AM_V_at)touch $@
    9899
    99100$(Programs_LLIntOffsetsExtractor_OBJECTS): DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h
     
    101102DerivedSources/JavaScriptCore/LLIntAssembly.h: Programs/LLIntOffsetsExtractor$(EXEEXT)
    102103        $(AM_V_GEN)$(RUBY) $(srcdir)/Source/JavaScriptCore/offlineasm/asm.rb $(srcdir)/Source/JavaScriptCore/llint/LowLevelInterpreter.asm Programs/LLIntOffsetsExtractor$(EXEEXT) $@
     104        $(AM_V_at)touch $@
    103105
    104106$(libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_OBJECTS): DerivedSources/JavaScriptCore/LLIntAssembly.h
     
    236238DerivedSources/JavaScriptCore/InspectorJSBackendDispatchers.cpp: DerivedSources/JavaScriptCore/InspectorJS.json $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspector.py $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspectorStrings.py
    237239        $(AM_V_GEN)$(PYTHON) $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspector.py $< --output_h_dir $(GENSOURCES_JAVASCRIPTCORE) --output_cpp_dir $(GENSOURCES_JAVASCRIPTCORE) --output_js_dir $(GENSOURCES_JAVASCRIPTCORE) --output_type JavaScript
     240        $(AM_V_at)touch $@
    238241        mkdir -p DerivedSources/JavaScriptCore/inspector
    239242        cp DerivedSources/JavaScriptCore/InspectorJSTypeBuilders.h DerivedSources/JavaScriptCore/InspectorJSFrontendDispatchers.h DerivedSources/JavaScriptCore/InspectorJSBackendDispatchers.h DerivedSources/JavaScriptCore/inspector
  • trunk/Source/WebCore/ChangeLog

    r161495 r161497  
     12014-01-08  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [Automake] Scripts for generated build targets do not necessarily produce their output
     4        https://bugs.webkit.org/show_bug.cgi?id=126378
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        * GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't
     9        assure the output is generated every time the script is invoked, most commonly due to unchanged
     10        * bindings/gobject/GNUmakefile.am: Simply move the gdom-gen-symbols file into the output file
     11        instead of copying it if the contents differ and removing it. This again ensures that the output
     12        file is always newer than its dependencies, even if the input hasn't changed.
     13
    1142014-01-08  Frédéric Wang  <fred.wang@free.fr>
    215
  • trunk/Source/WebCore/GNUmakefile.am

    r161385 r161497  
    361361DerivedSources/WebCore/InspectorWebBackendDispatchers.cpp: $(GENSOURCES_WEBCORE)/InspectorWeb.json $(GENSOURCES_JAVASCRIPTCORE)/InspectorJS.json $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspector.py $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspectorStrings.py $(GENSOURCES_JAVASCRIPTCORE)/InspectorJSTypeBuilders.h
    362362        $(AM_V_GEN)$(PYTHON) $(INSPECTOR_SCRIPTS_DIR)/CodeGeneratorInspector.py $(GENSOURCES_WEBCORE)/InspectorWeb.json $(GENSOURCES_JAVASCRIPTCORE)/InspectorJS.json --output_h_dir $(GENSOURCES_WEBCORE) --output_cpp_dir $(GENSOURCES_WEBCORE) --output_js_dir $(GENSOURCES_WEBCORE) --output_type Web
     363        $(AM_V_at)touch $@
    363364DerivedSources/WebCore/InspectorWebTypeBuilders.h: DerivedSources/WebCore/InspectorWebTypeBuilders.cpp
    364365DerivedSources/WebCore/InspectorWebTypeBuilders.cpp: DerivedSources/WebCore/InspectorWebFrontendDispatchers.h
     
    447448        $(AM_V_at)($(foreach idl, $(dom_binding_idls), echo $(idl) &&) true) >> $(idl_files_list)
    448449        $(AM_V_at)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/preprocess-idls.pl --defines "LANGUAGE_JAVASCRIPT=1 $(feature_defines)" --idlFilesList $(idl_files_list) --windowConstructorsFile $(window_constructors_file) --workerGlobalScopeConstructorsFile $(workerglobalscope_constructors_file) --sharedWorkerGlobalScopeConstructorsFile $(sharedworkerglobalscope_constructors_file) --dedicatedWorkerGlobalScopeConstructorsFile $(dedicatedworkerglobalscope_constructors_file) --supplementalDependencyFile $@
     450        $(AM_V_at)touch $@
    449451
    450452.PHONY: $(window_constructors_file) $(workerglobalscope_constructors_file) $(sharedworkerglobalscope_constructors_file) $(dedicatedworkerglobalscope_constructors_file)
  • trunk/Source/WebCore/bindings/gobject/GNUmakefile.am

    r160336 r161497  
    502502        $(AM_V_GEN)cat $(gdom_symbol_files) > gdom-gen-symbols \
    503503        && $(PYTHON) $(WebCore)/bindings/scripts/gobject-run-api-break-test $(WebCore)/bindings/gobject/webkitdom.symbols gdom-gen-symbols \
    504         && (cmp -s gdom-gen-symbols $@ || cp gdom-gen-symbols $@) \
    505         && rm -f gdom-gen-symbols
     504        && mv gdom-gen-symbols $@
    506505
    507506EXTRA_DIST += \
  • trunk/Source/WebKit2/ChangeLog

    r161481 r161497  
     12014-01-08  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [Automake] Scripts for generated build targets do not necessarily produce their output
     4        https://bugs.webkit.org/show_bug.cgi?id=126378
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        * GNUmakefile.am: Don't pass the -n option to the ln command that links the build's include
     9        directories to actual source directories. This doesn't replace the original symbolic link,
     10        which can lead to the actual link being older than its dependencies and subsequent constant
     11        relinking at every build.
     12
    1132014-01-07  Eric Carlson  <eric.carlson@apple.com>
    214
  • trunk/Source/WebKit2/GNUmakefile.am

    r161322 r161497  
    398398$(GENSOURCES_WEBKIT2)/webkit2gtk/include/webkit2: $(webkit2gtk_h_api)
    399399        $(AM_V_GEN)mkdir -p $(GENSOURCES_WEBKIT2)/webkit2gtk/include \
    400         && ln -n -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@
     400        && ln -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@
    401401
    402402$(GENSOURCES_WEBKIT2)/webkit2extension/include/webkit2: $(webkit2gtk_h_api)
    403403        $(AM_V_GEN)mkdir -p $(GENSOURCES_WEBKIT2)/webkit2extension/include \
    404         && ln -n -s -f ${shell pwd}/$(WebKit2)/WebProcess/InjectedBundle/API/gtk $@
     404        && ln -s -f ${shell pwd}/$(WebKit2)/WebProcess/InjectedBundle/API/gtk $@
    405405
    406406BUILT_SOURCES += \
Note: See TracChangeset for help on using the changeset viewer.